patchphpGroupWare - Patches: patch #786, Weather pagination fix

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #786: Weather pagination fix

Submitted by:  Shamim Islam <kellin>
Submitted on:  Mon 09 Dec 2002 05:56:19 AM UTC  
 
Category: weatherPriority: 5 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Mon 09 Dec 2002 06:47:30 AM UTC, comment #1:

Thanks for this, I will look at and test this patch, if it is upto scratch it will then be applied.

Unfortunately I have not been sucessful in having a working weather install since 0.9.14RCs. Both weather and comics are unmaintained apps at the moment. I appreciate your contribution to the project.

btw is this the same as patch #787 ?

Dave Hall <skwashd>
Project Administrator
Mon 09 Dec 2002 05:56:19 AM UTC, original submission:

Ok, I posted a bug a while back and got a message back saying that the latest CVs is correct. I have updated from the latest CVS and guess what, the thing STILL IS NOT CORRECT.

Let's try this. Set your items per page to 40. Set up 3 or 4 weather stations. Now try to view the weather.

Guess what? You can only see the first one.

Why is that? Because the weather system does not honor the number of matches properly and shows whatever it thinks is appropriate.

So, the patch here sets the matches manually just prior to showing the weather and guess what happens when you do that??

You can paginate. Even though the weather application is braindead enough to assume 1 weather station per page, you can fool it into thinking that the number of matches is the same as the number of stations even when it's not.

This is a one line patch that corrects this behavior.

Anyone care to take any bets that the comic system has to have me patch it before that same bug is corrected????

Shamim Islam <kellin>

 

Attached Files
file #4915:  patch_item_786.patch added by kellin (581B - text/plain - patch item 786)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by skwashd (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 06 Mar 2010 02:26:34 AM UTCskwashdAssigned toskwashd=>None
    Mon 09 Dec 2002 06:47:30 AM UTCskwashdAssigned toNone=>NA
      SummaryWeather DOES NOT PAGINATE!!!!!=>
    Mon 09 Dec 2002 05:58:17 AM UTCkellinPatch CodeModified - New Version=>

    Back to the top


    Powered by Savane 3.1-cleanup1