make - Patches: patch #7522, Fix crash in Windows when shell...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7522: Fix crash in Windows when shell name has parentheses
Submitter: | David Grayson <davidegrayson> | ||
Submitted: | Sun 03 Apr 2011 08:05:57 PM UTC | ||
Category: | None | Priority: | 7 - High |
Status: | Done | Privacy: | Public |
Assigned to: | eliz | Open/Closed: | Closed |
Fixed Release: | CVS |
Tue 24 May 2011 06:09:44 AM UTC, comment #4: |
David Grayson <davidegrayson> |
Sat 07 May 2011 08:50:20 AM UTC, comment #3: Answering my own question: yes, this is specific to Unixy shells only. Windows shells have special characters that cannot possibly appear in Windows file names, so this particular problem cannot happen with them.
|
Eli Zaretskii <eliz> |
Mon 25 Apr 2011 12:10:35 AM UTC, comment #2: Hello, Eli. Thank you for looking at my patch!
|
David Grayson <davidegrayson> |
Tue 19 Apr 2011 03:57:53 PM UTC, comment #1: Is this problem specific to unixy shells only? Because the method of protecting shell file names with spaces used by the nw function (and its code that was extracted from construct_command_argv_internal) will only work with Unixy shells; Windows shells don't support escaping characters with backslashes.
|
Eli Zaretskii <eliz> |
Sun 03 Apr 2011 08:05:57 PM UTC, original submission:
Recent versions of GNU Make, including version 3.82, crash in Windows if the Makefile contains commands that need to be executed using a shell (for example, "a && b") and the path to the shell contains parentheses (for example, "C:\Program Files (x86)\").
|
David Grayson <davidegrayson> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2011-05-07 | psmith | Assigned to | None | eliz | |
2011-05-07 | eliz | Status | None | Done | |
Open/Closed | Open | Closed | |||
Fixed Release | None | CVS | |||
2011-04-03 | davidegrayson | Attached File | - | Added win32_crash_fix.patch, #23093 | |
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-758e.
Corresponding source code
Hello, Eli.
Your patch looks good. After I changed all instances of "batch_filename_ptr" to "batch_filename_p", I was able to compile the latest version of make from CVS in Windows and I verified that it fixes the crash I was experiencing.
Thank you for looking at this and fixing it!
--David