PSPP - Patches: patch #6719, rewrite of interaction.c
You are not allowed to post comments on this tracker with your current authentication level.
patch #6719: rewrite of interaction.c
Submitter: | Jason H Stover <jstover> | ||
Submitted: | Fri 09 Jan 2009 08:55:16 PM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Mon 12 Jan 2009 12:39:20 AM UTC, comment #5: |
John Darrington <jmd> |
Sun 11 Jan 2009 10:25:49 PM UTC, comment #4: OK. Latest version attached.
|
Jason H Stover <jstover> |
Sat 10 Jan 2009 01:56:04 AM UTC, comment #3: I don't see any fundamental problem with that approach. It could use some refinement, but so far as I can see, that solution will allow you to start using the module. |
John Darrington <jmd> |
Sat 10 Jan 2009 01:00:43 AM UTC, comment #2: '4. It looks to me as if interaction_value_create is going to cause a buffer overflow. result->strings has a width of MAX_SHORT_STRING but you are writing to it MAX_SHORT_STRING * n_vars bytes + 1 bytes.'
|
Jason H Stover <jstover> |
Fri 09 Jan 2009 10:31:41 PM UTC, comment #1: I think its an improvement over the existing version. I'm beginning to understand what an "interaction" is now.
|
John Darrington <jmd> |
Fri 09 Jan 2009 08:55:16 PM UTC, original submission:
A new version of interaction.c is attached. If this looks OK, I will use this code to make covariance-matrix.c compute covariances when the user specifies interactions in a model.
|
Jason H Stover <jstover> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2009-01-12 | jstover | Status | Ready For Test/Review | Done | |
Open/Closed | Open | Closed | |||
2009-01-11 | jstover | Attached File | - | Added interaction.c, #17243 | |
Attached File | - | Added interaction.h, #17244 | |||
2009-01-09 | jstover | Attached File | - | Added interaction.c, #17232 | |
Attached File | - | Added interaction.h, #17233 |
Powered by Savane 3.13-cf05.
Corresponding source code
Minor gnits:
Otherwise I think it's fine.