patchPSPP - Patches: patch #6614, Rewrite EXAMINE

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6614: Rewrite EXAMINE

Submitter:  John Darrington <jmd>
Submitted:  Sun 17 Aug 2008 12:59:39 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 30 Aug 2008 05:08:42 PM UTC, comment #5: 

That worked, but the patch failed with src/math/automake.mk because of Ben's recent code related to Changelogs. So, it works, modulo the problem of merging automake.mk.


Jason H Stover <jstover>
Group Member
Sun 24 Aug 2008 07:13:35 AM UTC, comment #4: 

Here's an updated patch which also fixes a few problems related to missing values.

(file #16351)

John Darrington <jmd>
Group administrator
Mon 18 Aug 2008 09:14:55 PM UTC, comment #3: 

To pass make check, I had to chmod u+x examine-crash.sh manually.

Otherwise it looks good to me.

Jason H Stover <jstover>
Group Member
Sun 17 Aug 2008 10:19:07 PM UTC, comment #2: 


> I think you forgot to include unique-translator.h in the patch:


Thanks for pointing it out.  This #include line should have been deleted.

John Darrington <jmd>
Group administrator
Sun 17 Aug 2008 08:02:06 PM UTC, comment #1: 

I like the statistic struct.

I think you forgot to include unique-translator.h in the patch:

        gcc -std=gnu99 -DHAVE_CONFIG_H -I.  -I./gl -I./gl  -I./src/language/stats -I./src/language/expressions -I./src/language/expressions -I./src -I./lib -DPKGDATADIR=\"/usr/local/share/pspp\"  -Wall -W -Wwrite-strings -Wstrict-prototypes -Wpointer-arith -Wno-sign-compare -Wmissing-prototypes -g -O2 -Wdeclaration-after-statement -MT src/math/order-stats.o -MD -MP -MF $depbase.Tpo -c -o src/math/order-stats.o src/math/order-stats.c &&\
        mv -f $depbase.Tpo $depbase.Po
src/math/order-stats.c:24:36: error: data/unique-translator.h: No such file or directory

Jason H Stover <jstover>
Group Member
Sun 17 Aug 2008 12:59:39 PM UTC, original submission:  

This is a fairly major rewrite of the examine command and many of the things on which it depends.

In particular, it changes percentiles and similar statistics, so that it no longer dynamically allocates an array into which the data set is copied.  Instead, it iterates a casereader containing the data.  The only precondition is that this casereader must have been sorted on the key variable.

In addition other statistics such as tukey_hinges, trimmed mean etc, have been changed to have similar API to percentiles, and they can be calculated in the same iteration. 

In general, this change should make execution faster and re-use easier.  There are still opportunities for optimisation, but I think this is a big improvement.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16351:  ex.patch added by jmd (177KiB - text/x-diff)
file #16304:  examine.patch added by jmd (178KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-09-04 jmd StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2008-08-24 jmd Attached File- Added ex.patch, #16351
    2008-08-17 jmd Attached File- Added examine.patch, #16304

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code