patchPSPP - Patches: patch #6512, Don't use isnan, isinf, finite

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6512: Don't use isnan, isinf, finite

Submitted by:  Ben Pfaff <blp>
Submitted on:  Thu 15 May 2008 05:56:17 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  Ben Pfaff <blp>
Open/Closed:  Closed

Fri 16 May 2008 05:38:45 AM UTC, comment #5:

I checked this in, so I'm closing it.

I'll file a bug separately about not using GSL for these functions.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Fri 16 May 2008 05:37:42 AM UTC, comment #4:

See also additional discussion here:
http://thread.gmane.org/gmane.comp.statistics.pspp.devel/1870/focus=1879

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Thu 15 May 2008 05:08:03 PM UTC, comment #3:

Yes, that worked.

Jason H Stover <jstover>
Project Member
Thu 15 May 2008 04:27:04 PM UTC, comment #2:

Problems? Do you just mean trivially fixed patch rejects? I guess I'm OK with that.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.
Thu 15 May 2008 06:55:31 AM UTC, comment #1:

This will cause problems for anyone trying to apply patch #6245 but as that's not going to be part of 0.6.0 I suppose we shouldn't worry too much about that.

John Darrington <jmd>
Project Administrator
Thu 15 May 2008 05:56:17 AM UTC, original submission:

isnan and isinf cause trouble on Solaris, and the gnulib replacements are not ready yet. Therefore, use gsl_isnan and gsl_isinf instead, which should work everywhere.

Do the same for finite, for good measure.

Jason, does this fix the Solaris problems then?

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

Attached Files
file #15666:  isxxx.patch added by blp (8KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-05-16 blp StatusWorks For Me => Done
        Open/ClosedOpen => Closed
    2008-05-15 jstover Assigned tojstover => blp
    2008-05-15 jstover StatusReady For Test/Review => Works For Me
    2008-05-15 blp Attached File- => Added isxxx.patch, #15666

    Back to the top


    Powered by Savane 3.4