patchPSPP - Patches: patch #6506, Use watch cursor for long...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6506: Use watch cursor for long operations in text data import assistant

Submitter:  Ben Pfaff <blp>
Submitted:  Wed 07 May 2008 04:09:23 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  jmd
Open/Closed:  Closed

Fri 09 May 2008 12:01:38 AM UTC, comment #3: 


>That seems to have fixed the problem. Thanks.


Thanks.  I committed the patches and I'm closing this report.

Ben Pfaff <blp>
Group administrator
Thu 08 May 2008 03:46:31 AM UTC, comment #2: 

That seems to have fixed the problem.  Thanks.

John Darrington <jmd>
Group administrator
Wed 07 May 2008 03:18:53 PM UTC, comment #1: 

John wrote in pspp-dev:

> Upon applying this patch, I discover that my problem isn't caused by
> what I had thought.  What actually is happening is this:
>
> When the "Choose Separators" page is displayed for the first time
> after opening the assistant, the Forward button is unresponsive (at
> least to click events) until after the mouse cursor has been moved off
> the button, and back onto it  (typically the mouse cursor is over the
> button when the page appears, because it coincides with the position
> of the previous cursor).
>
> So if I try to just click through the Forward buttons, I get stuck at
> Choose Separators.  I have to wiggle the mouse in order to continue. 


Hmm.  OK.  Here's a patch that fixes that.  I couldn't figure out why
this behavior happens, so it just drops the requirement to visit every
page in the assistant.  The page that needs to get visited is the
final page, which is all that the assistant lets you skip to, so the
comment that gets deleted can be ignored.

I'm also attaching a gtksheet bug fix.  For whatever reason, clicking
the Last button triggered this GTK-critical that I hadn't seen
before.  Dunno why.


(file #15630, file #15631)

Ben Pfaff <blp>
Group administrator
Wed 07 May 2008 04:09:23 AM UTC, original submission:  

Some operations can take a long time in the text data import assistant, especially for big input files.  John suggested using a cursor that indicates this.  The attached patch implements this behavior.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-05-09 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2008-05-07 blp Attached File- Added text-import-fix-next-button.patch, #15630
        Attached File- Added gtksheet-fix-unrealize-critical.patch, #15631
    2008-05-07 blp Attached File- Added text-import-add-waiting-cursor.patch, #15623

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code