PSPP - Patches: patch #6488, test for QR decomposition in...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6488: test for QR decomposition in REGRESSION
Submitter: | Jason H Stover <jstover> | ||
Submitted: | Wed 09 Apr 2008 03:55:47 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Thu 17 Apr 2008 04:49:42 AM UTC, comment #5: |
John Darrington <jmd> |
Mon 14 Apr 2008 03:49:54 AM UTC, comment #4: If that's what you think best, then I'm happy with it. |
John Darrington <jmd> |
Mon 14 Apr 2008 03:15:30 AM UTC, comment #3: I was trying to make a test something like
|
Jason H Stover <jstover> |
Wed 09 Apr 2008 06:44:28 PM UTC, comment #2: Randomly generating the data might work, but then the test won't be a straightforward diff. If the least squares line passes exactly through the data, the standard errors of the estimated coefficients will be exactly 0. This stored standard error will be 0 to machine precision, or close to 0, and will then be used in the denominator of any test statistics appearing in the 't' and 'F' columns of the output tables. Since these values are close to, but not exactly 0, and also random, dividing by them will produce random, huge test statistics which will fail the diff. That's what happened to me when I ran the randomly-generated data through make check (output below).
13c13
19,21c19,21
run program
|
Jason H Stover <jstover> |
Wed 09 Apr 2008 05:36:22 AM UTC, comment #1: I suggest that instead of explicitly providing the test data, we generate it. Ie, something similar to:
|
John Darrington <jmd> |
Wed 09 Apr 2008 03:55:47 AM UTC, original submission:
This patch implements a test for the QR decomposition in REGRESSION. Note the test may fail unless it is run after applying John Darrington's patch for bug 22788.
|
Jason H Stover <jstover> |
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2008-04-17 | jmd | Status | None | Done | |
Open/Closed | Open | Closed | |||
2008-04-14 | jstover | Dependencies | - | bugs #22788 is dependent | |
2008-04-09 | jmd | Dependencies | - | Depends on bugs #22788 | |
2008-04-09 | jstover | Attached File | - | Added regression-test.patch, #15426 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Closing this patch, as it has been committed.