patchPSPP - Patches: patch #6412, GET DATA TYPE=TXT extensions

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6412: GET DATA TYPE=TXT extensions

Submitter:  Ben Pfaff <blp>
Submitted:  Fri 08 Feb 2008 05:10:55 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 10 Feb 2008 08:19:08 AM UTC, comment #4: 


>The changes to helper.[ch] don't seem to be used anywhere in this
>patch.


Oops.  I dropped this part.

>I suppose if this is a pspp extension, then it ought to be
>protected by the --syntax=enhanced flag.


You're right.  I fixed this.

Thanks for the review and testing.  I committed this patch.

Ben Pfaff <blp>
Group administrator
Fri 08 Feb 2008 06:03:51 PM UTC, comment #3: 


>After applying this patch and the patch for the import of text >data, I got a compilation error because INT_BUFSIZE_BOUND and >NOT_REACHED were undefined in /src/data/dictionary.c. I thought my >old copy of gnulib caused this, but updating didn't fix it.


Forget it. I was confused.

Jason H Stover <jstover>
Group Member
Fri 08 Feb 2008 04:23:29 PM UTC, comment #2: 

After applying this patch and the patch for the import of text data, I got a compilation error because INT_BUFSIZE_BOUND and NOT_REACHED were undefined in /src/data/dictionary.c. I thought my old copy of gnulib caused this, but updating didn't fix it.

Jason H Stover <jstover>
Group Member
Fri 08 Feb 2008 09:14:58 AM UTC, comment #1: 

The changes to helper.[ch] don't seem to be used anywhere in this patch.

I suppose if this is a pspp extension, then it ought to be protected by the --syntax=enhanced flag.


John Darrington <jmd>
Group administrator
Fri 08 Feb 2008 05:10:55 AM UTC, original submission:  

This patch adds a couple of extensions to GET DATA TYPE=TXT that make the text import dialog more useful.

Comments?

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-02-10 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2008-02-08 blp Attached File- Added get-data-type-txt-enhancements.patch, #14989

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code