patchPSPP - Patches: patch #6359, Eliminate var_get_value_name

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6359: Eliminate var_get_value_name

Submitter:  John Darrington <jmd>
Submitted:  Tue 01 Jan 2008 03:08:22 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 02 Jan 2008 04:13:23 AM UTC, comment #2: 

I checked this in with the changes you suggested.

If we deem it necessary we can add a separate function which returns an initialized string instead of appending,  but I don't think it's worthwhile just yet.

John Darrington <jmd>
Group administrator
Tue 01 Jan 2008 10:05:14 PM UTC, comment #1: 

Looks good.

Could you update the documentation on var_get_value_name in doc/dev/concepts.texi?

var_append_value_name could use ds_put_uninit instead of writing to a temporary buffer followed by ds_put_cstr.

It is a little sad that we have to add init and destroy calls for all of the users of the new function, but I don't see a way to avoid it.  Some of the uses can save one line of by using DS_EMPTY_INITIALIZER as an initializer instead of calling ds_init_empty, but it's not a big deal either way.

Ben Pfaff <blp>
Group administrator
Tue 01 Jan 2008 03:08:22 AM UTC, original submission:  

This patch replaces the var_get_value_name function with
var_append_value_name, and updates all users.  The new function avoids using any static data.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14730:  v.patch added by jmd (28KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-01-02 jmd StatusWorks For Me Done
        Open/ClosedOpen Closed
    2008-01-01 blp StatusReady For Test/Review Works For Me
    2008-01-01 jmd Attached File- Added v.patch, #14730

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code