patchPSPP - Patches: patch #6246, Use isfinite, round modules from...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6246: Use isfinite, round modules from gnulib

Submitter:  Ben Pfaff <blp>
Submitted:  Sun 28 Oct 2007 05:48:41 PM UTC
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 03 Nov 2007 02:33:02 AM UTC, comment #5: 

I checked this in.

Ben Pfaff <blp>
Project Administrator
Tue 30 Oct 2007 06:32:51 PM UTC, comment #4: 

> Dumb question, but are you using the new gnulib repository?


No, good question, and no, I was still using the cvs repository.
I installed git and got the latest copy of gnulib, and now it works fine.

Jason H Stover <jstover>
Project Member
Tue 30 Oct 2007 05:06:57 PM UTC, comment #3: 

>gnulib-tool: module isfinite doesn't exist


Dumb question, but are you using the new gnulib repository?  gnulib has moved from CVS to Git.  I think that the old CVS repository is still available, but frozen at an older point in time.

Even if you don't have Git installed, you can still download a snapshot of the gnulib tree through the gnulib gitweb at:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git

Ben Pfaff <blp>
Project Administrator
Tue 30 Oct 2007 05:01:15 PM UTC, comment #2: 

After applying the patch, I used a fresh checkout of gnulib, and
make -f Smake is complaining that it can't find
isfinite. The linker then breaks after compilation.

Here is the error from make -f Smake:

gnulib-tool: module isfinite doesn't exist

...it makes the same complaint about trunc
and round.

Jason H Stover <jstover>
Project Member
Mon 29 Oct 2007 09:20:08 AM UTC, comment #1: 

Looks good to me.

John Darrington <jmd>
Project Administrator
Sun 28 Oct 2007 05:48:41 PM UTC, original submission:  

I've added modules for "round" and "isfinite" to gnulib.  The attached patch uses them in PSPP.

This should remove the GSL dependency from src/data, mentioned by John as an issue for the Perl patch.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-11-03 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-10-28 blp Attached File- Added isfinite-round-from-gnulib.patch, #14238

    Back to the top


    Powered by Savane 3.9