patchPSPP - Patches: patch #6229, Independent Samples T-Test dialog

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6229: Independent Samples T-Test dialog

Submitter:  John Darrington <jmd>
Submitted:  Sun 07 Oct 2007 07:14:21 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Wed 10 Oct 2007 10:23:01 AM UTC, comment #6: 

I implemented your other suggestions and commited this patch.

John Darrington <jmd>
Group administrator
Tue 09 Oct 2007 01:18:11 PM UTC, comment #5: 


>That's not what it does.


Well, never mind then.

Ben Pfaff <blp>
Group administrator
Tue 09 Oct 2007 10:14:25 AM UTC, comment #4: 


> It is not obvious to me from the interface that clicking Continue > in the Define Groups dialog box enables grouping and that clicking Cancel disables it, but I think that that is what happens. > It would be clearer if there were a radio button selection: "Do not group" versus "Divide into two groups:", or something equivalent.


That's not what it does.  There are always two groups defined. A T-Test is meaningless otherwise. The Define Groups dialog box allows you to choose the values (of the grouping variable) which determine which cases belong to which group.

John Darrington <jmd>
Group administrator
Tue 09 Oct 2007 04:07:11 AM UTC, comment #3: 

I have some nitpicks on the dialogs.

The Define Groups button pops up a dialog box, I think, so customarily its label should end in "...".

What goes in the Group 1 and Group 2 entries was really puzzling to me until I read the documentation.  I think that a numeric value must be put in each text entry.  Perhaps the labels could make this clearer, e.g. "Group 1 value".

It is not obvious to me from the interface that clicking Continue in the Define Groups dialog box enables grouping and that clicking Cancel disables it, but I think that that is what happens.  It would be clearer if there were a radio button selection: "Do not group" versus "Divide into two groups:", or something equivalent.

Otherwise looks good to me.

Ben Pfaff <blp>
Group administrator
Mon 08 Oct 2007 11:23:40 AM UTC, comment #2: 

Sorry.

Try this one.

I've not implemented the {EXCLUDE,INCLUDE} option, because other software also doesn't.

(file #14113)

John Darrington <jmd>
Group administrator
Sun 07 Oct 2007 08:27:50 PM UTC, comment #1: 

There's a comment in generate_syntax that mentions {EXCLUDE,INCLUDE} but no code that generates it.

Otherwise it looks OK, but you didn't include the new glade files in the patch.

Ben Pfaff <blp>
Group administrator
Sun 07 Oct 2007 07:14:21 AM UTC, original submission:  

I think this is more or less ready.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #14113:  tt.patch added by jmd (40KiB - text/x-diff)
file #14109:  indep-samples-tt.patch added by jmd (17KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-10 jmd StatusWorks For Me Done
        Assigned toblp None
        Open/ClosedOpen Closed
    2007-10-09 blp StatusReady For Test/Review Works For Me
    2007-10-08 jmd Attached File- Added tt.patch, #14113
    2007-10-07 jmd Attached File- Added indep-samples-tt.patch, #14109

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code