patchPSPP - Patches: patch #6219, Descriptives Dialog

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6219: Descriptives Dialog

Submitter:  Ben Pfaff <blp>
Submitted:  Sat 29 Sep 2007 03:17:48 PM UTC
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

( Jump to the original submission )

Sat 06 Oct 2007 04:25:22 AM UTC, comment #14: 

>The "Save Z Scores ...." checkbox doesn't belong in the "Missing
>Value Treatment" frame.


I changed the label on the frame to "Options".  OK?

With that change, I checked this in.

Ben Pfaff <blp>
Project Administrator
Fri 05 Oct 2007 09:54:51 AM UTC, comment #13: 

Just one comment:

The "Save Z Scores ...." checkbox doesn't belong in the "Missing Value Treatment" frame.  Move it outside.

John Darrington <jmd>
Project Administrator
Fri 05 Oct 2007 04:51:02 AM UTC, comment #12: 

I think that I've addressed all suggestions with the attached patch.  If there are no additional comments, I'll check it in soon.

(file #14087)

Ben Pfaff <blp>
Project Administrator
Wed 03 Oct 2007 05:00:23 AM UTC, comment #11: 

>The title bar displays "Sort Cases".


Thanks, I've fixed this in my working tree.  (I started by copying the Sort Cases dialog and then adjusting things a bit.)

>The refresh button doesn't reset any of the checkboxes back to
>their initial states.


I'll be sure to fix that.  Thanks!

Is the label Refresh chosen for compatibility's sake?  To me, Reset is a more descriptive name.

Ben Pfaff <blp>
Project Administrator
Wed 03 Oct 2007 04:34:11 AM UTC, comment #10: 

And another thing:

The refresh button doesn't reset any of the checkboxes back to their initial states.  That's what I would expect it to do.

John Darrington <jmd>
Project Administrator
Tue 02 Oct 2007 06:03:39 AM UTC, comment #9: 

One other problem I just noticed:

The title bar displays "Sort Cases".

John Darrington <jmd>
Project Administrator
Tue 02 Oct 2007 04:43:34 AM UTC, comment #8: 

Regarding comment #1 and comment #6, I applied all of your suggestions to my tree.

>4. I think the dialog box looks nicer if you set the following
>widget properties:


I'm glad someone around here has some taste in GUI design, as I have none.  About the only real GUI I use on a day-to-day basis is Firefox (Iceweasel, actually), and I'm not sure that counts.

I have other questions, which I will bring up on pspp-dev.

Ben Pfaff <blp>
Project Administrator
Tue 02 Oct 2007 03:24:50 AM UTC, comment #7: 

>I think this patch (to be applied on top of Ben's patch) fixes the
>problem.


Your patch is "obviously correct", thanks.

Now I know about g_free.

Ben Pfaff <blp>
Project Administrator
Tue 02 Oct 2007 03:11:47 AM UTC, comment #6: 

After playing around a bit more, I started to get similar symptoms.

I think this patch (to be applied on top of Ben's patch) fixes the problem.

(file #14058)

John Darrington <jmd>
Project Administrator
Tue 02 Oct 2007 02:39:43 AM UTC, comment #5: 

At John's suggestion, I just re-ran the job
and selected 'Paste'. A new window opened and
had only the word 'Sans' in it.

It still segfaults.

Jason H Stover <jstover>
Project Member
Tue 02 Oct 2007 02:16:24 AM UTC, comment #4: 

Here are some details about the segfault: In the data
editor, I added variables v1 and v2, typed in some random
data on the keyboard (about 10 cases in the two columns),
selected the Descriptives procedure with variable v1, hit 'OK'.
psppire segfaulted, and gdb reported this backtrace:

Program received signal SIGSEGV, Segmentation fault.
0xb7276fe4 in _IO_str_overflow_internal () from /lib/libc.so.6
(gdb) bt
#0  0xb7276fe4 in _IO_str_overflow_internal () from /lib/libc.so.6
#1  0xb7276984 in __overflow () from /lib/libc.so.6
#2  0xb726b442 in vsprintf () from /lib/libc.so.6
#3  0x08145bfd in ds_put_vformat (st=0xb734fff4, format=0x84780a0 "", args_=0x0) at src/libpspp/str.c:1291
#4  0x080a2f67 in create_syntax_string_source (format=0x84780a0 "") at src/language/syntax-string-source.c:111
#5  0x08070743 in descriptives_dialog (o=0x8381498, data=0x81f5a20) at src/ui/gui/descriptives-dialog.c:316
#6  0xb776eb6b in IA__g_cclosure_marshal_VOID__VOID (closure=0x8381e18, return_value=0x0, n_param_values=1,
    param_values=0xbfbc9e4c, invocation_hint=0xbfbc9d4c, marshal_data=0x8070510) at gmarshal.c:77
#7  0xb7761cdc in IA__g_closure_invoke (closure=0x8381e18, return_value=0x0, n_param_values=1,
    param_values=0xbfbc9e4c, invocation_hint=0xbfbc9d4c) at gclosure.c:490
#8  0xb7772574 in signal_emit_unlocked_R (node=0x8370000, detail=0, instance=0x8381498, emission_return=0x0,
    instance_and_params=0xbfbc9e4c) at gsignal.c:2440
#9  0xb7773a9c in IA__g_signal_emit_valist (instance=0x8381498, signal_id=243, detail=0,
    var_args=0xbfbca08c "D\235ù·\230\0248\bX]8\b¸ ¼¿\bÔÊ·\230\0248\bà\207\037\bø ¼¿\212ÓÊ·è\006y·\200ÓÊ·è ¼¿këv·\230\0248\b\030ä!\b\002") at gsignal.c:2199
#10 0xb7773c4e in IA__g_signal_emit (instance=0x8381498, signal_id=243, detail=0) at gsignal.c:2243
#11 0xb7cac5dc in ?? () from /usr/lib/libgtk-x11-2.0.so.0

Jason H Stover <jstover>
Project Member
Tue 02 Oct 2007 02:14:34 AM UTC, comment #3: 

I didn't get any problems of that sort.  Perhaps you could try:

1. to get a stacktrace.

2. post the data you entered.

3. hit "Paste"  instead of "OK" and see waht syntax gets generated.

John Darrington <jmd>
Project Administrator
Tue 02 Oct 2007 02:08:15 AM UTC, comment #2: 

It looked good, but I entered data into the
spreadsheet, then selected descriptives, hit
'OK', and psppire segfaulted.

Jason H Stover <jstover>
Project Member
Sat 29 Sep 2007 11:45:10 PM UTC, comment #1: 

It seems pretty good to me.

1. In data-editor.c,  you should change    ("Descriptives") to ("_Descriptives") so it'll preserve the accelerator key for the menu item.

2. put_statistics_in_treeview should be static

3. Other software has a "Save standardized values as variables" checkbox to implement the /SAVE option.

4. I think the dialog box looks nicer if you set the following widget properties:

 frame11: FrameShadow = "Etched In"
 vbox30:  Padding = 5
 vbox31:  Padding = 5
 scrolledwindow14: ShadowType = "Etched In"

5. Putting all the options in a treeview is a good idea.  However it departs from the user interface of the Chicargo company's software.  I've been tending to follow their UI fairly closely, even though it sometimes conflicts with the Gtk/Gnome HIG.  I guess at some stage we should decide upon some semi-formal policy  here.

John Darrington <jmd>
Project Administrator
Sat 29 Sep 2007 03:17:48 PM UTC, original submission:  

Here's a dialog box for descriptive statistics.  Seems to work.  Please review carefully, as this is the first Gtk code I have ever written.

Ben Pfaff <blp>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #14087:  descriptives-gui-2.patch added by blp (32KiB - text/x-diff)
file #14058:  desc-fix.patch added by jmd (680B - text/x-diff)
file #14043:  descriptives-gui.patch added by blp (30KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-06 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-10-05 blp Attached File- Added descriptives-gui-2.patch, #14087
    2007-10-02 jmd Attached File- Added desc-fix.patch, #14058
    2007-09-29 blp Attached File- Added descriptives-gui.patch, #14043

    Back to the top


    Powered by Savane 3.9