patchPSPP - Patches: patch #6131, Output Viewer

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6131: Output Viewer

Submitter:  John Darrington <jmd>
Submitted:  Fri 03 Aug 2007 03:39:36 AM UTC
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

( Jump to the original submission )

Thu 16 Aug 2007 06:34:08 AM UTC, comment #11: 

> Would it make a visible performance difference to read in data more than one byte at a time? (Quite possibly, it would not.) We could do that easily, if we did not try to interpret backspaces. If backspaces are appearing in the output, then they can be disabled by specifying "emphasis=none" in the configuration string.


This is obviously a better way to do it, so that's what I have done.

John Darrington <jmd>
Project Administrator
Wed 15 Aug 2007 03:46:05 AM UTC, comment #10: 

>Comments?


The code looks good, although I did not test it (if you would like me to test it, let me know).

Would it make a visible performance difference to read in data more than one byte at a time?  (Quite possibly, it would not.)  We could do that easily, if we did not try to interpret backspaces.  If backspaces are appearing in the output, then they can be disabled by specifying "emphasis=none" in the configuration string.

Ben Pfaff <blp>
Project Administrator
Tue 14 Aug 2007 01:21:34 AM UTC, comment #9: 

Here's a new patch against the current head.

Comments?

(file #13663)

John Darrington <jmd>
Project Administrator
Sat 11 Aug 2007 01:40:22 AM UTC, comment #8: 

I want to work on this some more, before checking it in.  It's not very robust as is.

John Darrington <jmd>
Project Administrator
Fri 10 Aug 2007 09:30:35 PM UTC, comment #7: 

John, are you waiting for anything from me on this patch?  I'm OK with it being checked in.

Ben Pfaff <blp>
Project Administrator
Mon 06 Aug 2007 12:45:12 AM UTC, comment #6: 

I wrote:

>> BTW when I tried to start PSPPIRE without installing the
>> output-viewer.glade, it segfaulted. Probably worth fixing
>> that one too but I didn't look into it yet.


John replied:

> But you got a lot of GtkCriticals first?


Oh, probably.  I get a fair amount of spew in the console window.  I
tend to just ignore it.  Let me know if it's important and I'll
re-test.

Ben Pfaff <blp>
Project Administrator
Mon 06 Aug 2007 12:33:34 AM UTC, comment #5: 

Thanks for the patch.

> BTW when I tried to start PSPPIRE without installing the output-viewer.glade, it segfaulted. Probably worth fixing that one too but I didn't look into it yet.


But you got a lot of GtkCriticals first?  If you do "export G_DEBUG=fatal_criticals" then it will terminate on the first one.

John Darrington <jmd>
Project Administrator
Sun 05 Aug 2007 06:06:25 PM UTC, comment #4: 

It looks to me like the definition of struct output_viewer could be moved from the header file into output-viewer.c.

I'd prefer "w" mode versus "a" mode be controlled by an output driver setting instead of hard-coded.

It's probably better if the GUI configures its own output devices instead of reading them from the configuration file.

I'm attaching an incremental patch (that applies on top of yours) that implements all of these things.  It works for me.

BTW when I tried to start PSPPIRE without installing the output-viewer.glade, it segfaulted.  Probably worth fixing that one too but I didn't look into it yet.

(file #13596)

Ben Pfaff <blp>
Project Administrator
Sat 04 Aug 2007 01:12:35 AM UTC, comment #3: 

Having finger trouble today.

Here is output-viewer.glade

(file #13584)

John Darrington <jmd>
Project Administrator
Sat 04 Aug 2007 12:39:18 AM UTC, comment #2: 

Oops ... and output-viewer.glade too.

Here they are.

(file #13581, file #13582, file #13583)

John Darrington <jmd>
Project Administrator
Fri 03 Aug 2007 09:33:47 PM UTC, comment #1: 

output-viewer.[ch] look like they're missing from the patch.

Ben Pfaff <blp>
Project Administrator
Fri 03 Aug 2007 03:39:36 AM UTC, original submission:  

Here's a not very elegant, barely usable output viewer.

I tried numerous things to force the output driver into SCREEN mode, but in the end I had to just comment that flag out of src/output/output.c  I also made the ascii driver open its files in append mode, otherwise they suddenly got truncated which confused things no end.

Comments appreciated.

NB.  Don't try any of the menu items, because they don't do anything.

John Darrington <jmd>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #13663:  output.patch added by jmd (66KiB - text/x-diff)
file #13596:  gui-output-viewer-blp.patch added by blp (6KiB - text/x-diff)
file #13584:  output-viewer.glade added by jmd (12KiB - application/x-glade)
file #13582:  output-viewer.c added by jmd (3KiB - text/x-csrc)
file #13583:  output-viewer.h added by jmd (1KiB - text/x-chdr)
file #13562:  op.patch added by jmd (7KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 16 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-08-16 jmd StatusWorks For Me Done
        Assigned tojmd None
        Open/ClosedOpen Closed
    2007-08-15 blp StatusReady For Test/Review Works For Me
    2007-08-14 jmd Attached File- Added output.patch, #13663
        StatusIn Progress Ready For Test/Review
    2007-08-11 jmd StatusWorks For Me In Progress
        Assigned toblp jmd
    2007-08-10 blp StatusReady For Test/Review Works For Me
    2007-08-05 blp Attached File- Added gui-output-viewer-blp.patch, #13596
    2007-08-05 blp Attached File#13581 Removed
    2007-08-04 jmd Attached File- Added output-viewer.glade, #13584
    2007-08-04 jmd Attached File- Added output-viewer.c, #13581
        Attached File- Added output-viewer.c, #13582
        Attached File- Added output-viewer.h, #13583
    2007-08-03 jmd Attached File- Added op.patch, #13562

    Back to the top


    Powered by Savane 3.9