patchPSPP - Patches: patch #5917, dictionary documents patch

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5917: dictionary documents patch

Submitter:  John Darrington <jmd>
Submitted:  Sat 05 May 2007 09:19:34 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 06 May 2007 10:05:22 PM UTC, comment #3: 


>I'd prefer dict_set_documents to silently pad the string to 80
>byte boundary rather than asserting.


OK.  With that change, I checked this in.

Ben Pfaff <blp>
Group administrator
Sat 05 May 2007 11:42:52 PM UTC, comment #2: 

I'm happy with that, except that I'd prefer dict_set_documents to silently pad the string to 80 byte boundary rather than asserting.
But if that's a problem then I can live with this patch as is.

John Darrington <jmd>
Group administrator
Sat 05 May 2007 07:27:10 PM UTC, comment #1: 

How about something like this instead.  It is slightly simpler and makes it easier to copy documents between dictionaries.  I also cleaned up the implementation of cmd_document() to follow the style that I see SPSS and cmd_add_document() using.

(file #12703)

Ben Pfaff <blp>
Group administrator
Sat 05 May 2007 09:19:34 AM UTC, original submission:  

This patch cleans up the dict_*_documents functions.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12703:  documents2.patch added by blp (20KiB - text/x-diff)
file #12699:  docs.patch added by jmd (17KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Updated the item)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-05-06 blp StatusReady For Test/Review Done
        Open/ClosedOpen Closed
    2007-05-05 blp Attached File- Added documents2.patch, #12703
    2007-05-05 jmd Attached File- Added docs.patch, #12699

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code