patchPSPP - Patches: patch #5874, Automatically add long name table.

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5874: Automatically add long name table.

Submitter:  John Darrington <jmd>
Submitted:  Thu 19 Apr 2007 06:41:38 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 20 Apr 2007 10:40:19 AM UTC, comment #2: 


>It might be slightly clearer to write:
>strcpy (long_name, short_name);
>str_lowercase (long_name);


Thanks.  I'll do that.

>I wonder whether we should add a dictionary function to set both >long and short names at the same time. It would avoid the need to >duplicate the long comment, for one.


Maybe, although I can't see any need to do this outside {sys,por}-file-reader.c

John Darrington <jmd>
Group administrator
Thu 19 Apr 2007 03:15:00 PM UTC, comment #1: 

Looks good.  A few nits:

It might be slightly clearer to write:
  strcpy (long_name, short_name);
  str_lowercase (long_name);

I wonder whether we should add a dictionary function to set both long and short names at the same time.  It would avoid the need to duplicate the long comment, for one.

In the future please consider using "cvs -q diff".  It makes patches slightly easier to read by dropping all the "? unknown/file/name" lines.

Ben Pfaff <blp>
Group administrator
Thu 19 Apr 2007 06:41:38 AM UTC, original submission:  

This patch emulates the behaviour of other software.

When reading a sys file created by legacy versions, which doesn't have long variable names, it automatically adds long names to the dictionary.  The "long" names are the lower case versions of the short names.

The result is, that old sysfiles (for which only upper case names were permitted) get their names automatically converted to lower case.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12526:  sf.patch added by jmd (8KiB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-20 jmd StatusWorks For Me Done
        Open/ClosedOpen Closed
    2007-04-19 blp StatusReady For Test/Review Works For Me
    2007-04-19 jmd Attached File- Added sf.patch, #12526

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code