patchPSPP - Patches: patch #5841, Implement "tower" data...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5841: Implement "tower" data structure

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 01 Apr 2007 07:38:00 PM UTC  
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Tue 03 Apr 2007 10:55:53 PM UTC, comment #3: 


Thanks for the review.

Ben Pfaff <blp>
Project Administrator
Mon 02 Apr 2007 02:13:26 AM UTC, comment #2: 

That's right.  The client code is responsible for all memory management.  Although this makes some things slightly harder (specifically, you have to go through a <structure>_data macro to get from a node to client data), it reduces the number of needed calls to malloc and friends, reduces the amount of space overhead, and makes it easy to determine the node associated with given client data.

The tradeoffs are covered fairly well in the big comment at the top of src/libpspp/ll.h.

Thanks for the reviews.

Ben Pfaff <blp>
Project Administrator
Mon 02 Apr 2007 12:33:33 AM UTC, comment #1: 

I can't see any problems here.

The lack of a tower_destroy function, and the lack of any node_free function in all these structures suggests that the structure never takes ownership of the node data?

John Darrington <jmd>
Project Administrator
Sun 01 Apr 2007 07:38:00 PM UTC, original submission:  

This is second-to-last in the litany of supporting data structures wanted by the datasheet implementation.  (Are we done yet?)

This one is less conventional than the others.  The name is my own invention, although certainly the data structure itself has been implemented many times by others.

Ben Pfaff <blp>
Project Administrator


Attached Files
file #12367:  tower.tar.gz added by blp (7KiB - application/gzip)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-03 blp StatusWorks For Me => Done
        Open/ClosedOpen => Closed
    2007-04-02 jmd StatusReady For Test/Review => Works For Me
    2007-04-01 blp Attached File- => Added tower.tar.gz, #12367

    Back to the top

    Powered by Savane 3.5