patchPSPP - Patches: patch #5818, relocation

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5818: relocation

Submitter:  John Darrington <jmd>
Submitted:  Sun 25 Mar 2007 11:30:46 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sun 25 Mar 2007 10:17:42 PM UTC, comment #3: 


>Basically, libglade has been designed to load custom widgets
>dynamically, so we need the -rpath flag even if not relocating.


So that's just my ignorance of libglade showing.  OK.

>The reason I used macros was that I can use literal string
>concatenation, which isn't possible with functions.


Maybe we should implement a "relocate_asprintf" that accepts a printf-style format string and relocates it.  But macros are OK.

Ben Pfaff <blp>
Group administrator
Sun 25 Mar 2007 10:13:38 PM UTC, comment #2: 

  I don't know what's going on with the -rpath flags, but I'll  assume that you do.

Basically, libglade has been designed  to load custom widgets dynamically, so we need the -rpath flag even if not relocating.

  I'm a little uncomfortable using macros for XML_NEW, PIXBUF_NEW_FROM_FILE, instead of functions, but it's not a big deal.

I'm open to suggestions.  The reason I used macros was that I can use literal string concatenation, which isn't possible with functions.


John Darrington <jmd>
Group administrator
Sun 25 Mar 2007 10:02:18 PM UTC, comment #1: 

Thank you for preparing this.  It looks good to me.  I have only a few comments:

I don't know what's going on with the -rpath flags, but I'll assume that you do.

I'm a little uncomfortable using macros for XML_NEW, PIXBUF_NEW_FROM_FILE, instead of functions, but it's not a big deal.

I suspect that there are other places we should be using relocate, but it should be easy to fix these as we find them.

As for the strings in version.c, I guess we could write a relocate_path function that applies relocate to each directory in a path.

Ben Pfaff <blp>
Group administrator
Sun 25 Mar 2007 11:30:46 AM UTC, original submission:  

This patch makes pspp and psppire relocatable using the module from  gnulib.

Something still needs to be done about the strings in src/libpspp/version.c, but other than that, I think it all works fine.


John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #12292:  relocate.patc added by jmd (19KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-03-26 jmd StatusWorks For Me Done
        Open/ClosedOpen Closed
    2007-03-25 blp StatusReady For Test/Review Works For Me
    2007-03-25 jmd Attached File- Added relocate.patc, #12292

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code