PSPP - Patches: patch #5704, Data New/Open/Save
You are not allowed to post comments on this tracker with your current authentication level.
patch #5704: Data New/Open/Save
Submitter: | John Darrington <jmd> | ||
Submitted: | Tue 23 Jan 2007 12:28:23 PM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Tue 23 Jan 2007 05:16:44 PM UTC, comment #1: |
Ben Pfaff <blp> |
Tue 23 Jan 2007 12:28:23 PM UTC, original submission:
This patch re-enables the data new, open and save items in the data editor's file menu. This time, they simply call the relevant syntax, rather than using their own nefarious code like before.
|
John Darrington <jmd> |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-01-24 | jmd | Status | Works For Me | Done | |
Assigned to | jmd | None | |||
Open/Closed | Open | Closed | |||
2007-01-23 | blp | Status | Ready For Test/Review | Works For Me | |
Assigned to | blp | jmd | |||
2007-01-23 | jmd | Attached File | - | Added new-file.patch, #11824 |
Powered by Savane 3.13-02a9.
Corresponding source code
I'd suggest adding a function, analogous to the "quote" function in gnulib, that returns its argument as a quoted string in syntax format. It could return it in single quotes if it doesn't contain a single quote, in double quotes if it doesn't contain a double quote, or in single quotes with doubled single quotes otherwise. If we don't do something like this, then we end up with little ticking time bombs of code like this:
Otherwise, looks good.