patchPSPP - Patches: patch #5690, Clean up case code

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5690: Clean up case code

Submitter:  Ben Pfaff <blp>
Submitted:  Mon 15 Jan 2007 07:08:45 PM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  blp
Open/Closed:  Closed

Tue 16 Jan 2007 03:50:31 PM UTC, comment #4: 


>Much of the case.* code makes memory access at a lowish level. I
>just thought that if any mistakes have been made about sizes of
>data types, then these modules might be where they'd show up.


Oh.  You're quite possibly right, but I don't have a convenient 64-bit machine to try it on.

One of these days I should buy an x86-64 box.

I checked this in, then.

Ben Pfaff <blp>
Group administrator
Tue 16 Jan 2007 11:59:23 AM UTC, comment #3: 


> No, do you expect them to be arch-sensitive? (I did test them under valgrind.) I'm curious about the answer so I'll delay checking in until I hear back.


Much of the case.* code makes memory access at a lowish level.  I just thought that if any mistakes have been made about sizes of data types, then these modules might be where they'd show up.

John Darrington <jmd>
Group administrator
Tue 16 Jan 2007 12:18:55 AM UTC, comment #2: 


>case_is_null could return bool.


Thanks, updated.

>You need to visit each of the changed files in emacs and do M-x copyright-update


Ditto.

>I wonder if you've tested these changes on ix64 or any other architectures?


No, do you expect them to be arch-sensitive?  (I did test them under valgrind.)  I'm curious about the answer so I'll delay checking in until I hear back.

Ben Pfaff <blp>
Group administrator
Mon 15 Jan 2007 11:25:57 PM UTC, comment #1: 

case_is_null could return bool.

You need to visit each of the changed files in emacs and do M-x copyright-update

I wonder if you've tested these changes on ix64 or any other architectures?

Otherwise no problems.

John Darrington <jmd>
Group administrator
Mon 15 Jan 2007 07:08:45 PM UTC, original submission:  

This cleans up and improves case.[ch] and fixes some bugs found in the process.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11761:  case.patch added by blp (29KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-01-16 blp StatusWorks For Me Done
        Open/ClosedOpen Closed
    2007-01-16 jmd Assigned tojmd blp
    2007-01-16 blp Assigned toblp jmd
    2007-01-15 jmd StatusReady For Test/Review Works For Me
        Assigned tojmd blp
    2007-01-15 blp Attached File- Added case.patch, #11761

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code