patchPSPP - Patches: patch #5676, Add syntax-string-source

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5676: Add syntax-string-source

Submitted by:  John Darrington <jmd>
Submitted on:  Fri 12 Jan 2007 05:24:35 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 12 Jan 2007 10:59:10 PM UTC, comment #2: 

> The command name is WEIGHT, I don't think WEIGHTS will work.


Thanks.

> In the src/ui/gui/data-editor.c changes, isn't a lot of code duplicated between the GTK_RESPONSE_OK and PSPPIRE_RESPONSE_PASTE cases?


You're right.  I need to do something about this, as a lot of dialog boxes will have exactly the same semantics.  I just haven't decided on the best approach yet.

John Darrington <jmd>
Project Administrator
Fri 12 Jan 2007 03:48:44 PM UTC, comment #1: 

>So the question is, should it stay in src/ui/gui or somewhere lower level ?


I wouldn't argue with either choice.

Comments:

>           sss = create_syntax_string_source ("WEIGHTS OFF.");


The command name is WEIGHT, I don't think WEIGHTS will work.

In the src/ui/gui/data-editor.c changes, isn't a lot of code duplicated between the GTK_RESPONSE_OK and PSPPIRE_RESPONSE_PASTE cases?

Ben Pfaff <blp>
Project Administrator
Fri 12 Jan 2007 05:24:35 AM UTC, original submission:  

This patch introduces another implementation of struct getl_interface.  It stores it's syntax as a buffer.

I'm using it for the return values of the dialog boxes, but it occurred to me, that it might be usefull for other purposes too. (maybe for implementing macros?)

So the question is, should it stay in src/ui/gui or somewhere lower  level ?

John Darrington <jmd>
Project Administrator

 

Attached Files
file #11727:  x.patch added by jmd (17KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-01-20 jmd StatusWorks For Me => Done
        Assigned tojmd => None
        Open/ClosedOpen => Closed
    2007-01-12 blp StatusReady For Test/Review => Works For Me
        Assigned toNone => jmd
    2007-01-12 jmd Attached File- => Added x.patch, #11727

    Back to the top


    Powered by Savane 3.5