patchPSPP - Patches: patch #5672, Yet more procedure / dictionary...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5672: Yet more procedure / dictionary changes.

Submitted by:  John Darrington <jmd>
Submitted on:  Tue 09 Jan 2007 10:28:17 PM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 10 Jan 2007 12:39:46 AM UTC, comment #2: 

You're right.  I probably wasn't thinking straight when I made that edit.

John Darrington <jmd>
Project Administrator
Tue 09 Jan 2007 10:50:16 PM UTC, comment #1: 

The change to dict_delete_var worries me: now the callback will be called with the vardict indexes wrong, because variables have been moved around in the vars array but their indexes have not been updated in the vardicts.  This means that some operations on variables will assert-fail (anything that asserts on dict_contains_var, for example) if called within the callback.  Seems worrisome given the stated purpose of this change.

Otherwise fine by me.

Ben Pfaff <blp>
Project Administrator
Tue 09 Jan 2007 10:28:17 PM UTC, original submission:  

This patch contains further changes to ensure that callbacks occur as appropriate, and only when the dictionary and/or dataset is in a consistent state.

I think we're close now, as the GUI is finally accepting nearly all syntax I throw at it, without critical errors.

Syntax involving the NEW FILE command is still problematic, but all others work so far as I'm aware.  Let me know if you find any which gives problems.

John Darrington <jmd>
Project Administrator

 

Attached Files
file #11717:  x.patch added by jmd (10KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Posted a comment)
  • -email is unavailable- added by jmd (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-01-10 jmd StatusWorks For Me => Done
        Assigned tojmd => None
        Open/ClosedOpen => Closed
    2007-01-09 blp StatusReady For Test/Review => Works For Me
        Assigned toblp => jmd
    2007-01-09 jmd Attached File- => Added x.patch, #11717

    Back to the top


    Powered by Savane 3.5