PSPP - Patches: patch #5672, Yet more procedure / dictionary...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5672: Yet more procedure / dictionary changes.
Submitter: | John Darrington <jmd> | ||
Submitted: | Tue 09 Jan 2007 10:28:17 PM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Wed 10 Jan 2007 12:39:46 AM UTC, comment #2: |
John Darrington <jmd> |
Tue 09 Jan 2007 10:50:16 PM UTC, comment #1: The change to dict_delete_var worries me: now the callback will be called with the vardict indexes wrong, because variables have been moved around in the vars array but their indexes have not been updated in the vardicts. This means that some operations on variables will assert-fail (anything that asserts on dict_contains_var, for example) if called within the callback. Seems worrisome given the stated purpose of this change.
|
Ben Pfaff <blp> |
Tue 09 Jan 2007 10:28:17 PM UTC, original submission:
This patch contains further changes to ensure that callbacks occur as appropriate, and only when the dictionary and/or dataset is in a consistent state.
|
John Darrington <jmd> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-01-10 | jmd | Status | Works For Me | Done | |
Assigned to | jmd | None | |||
Open/Closed | Open | Closed | |||
2007-01-09 | blp | Status | Ready For Test/Review | Works For Me | |
Assigned to | blp | jmd | |||
2007-01-09 | jmd | Attached File | - | Added x.patch, #11717 |
Powered by Savane 3.13-4448.
Corresponding source code
You're right. I probably wasn't thinking straight when I made that edit.