patchPSPP - Patches: patch #5633, Don't break PSPP compile into libs

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5633: Don't break PSPP compile into libs

Submitted by:  Ben Pfaff <blp>
Submitted on:  Mon 11 Dec 2006 02:51:37 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 14 Dec 2006 03:29:24 AM UTC, comment #5: 

>Let's make src/language and subdirs into one big library, keeping
>the other libraries as they are.


Fine by me.  I'll take your word for it that it passes "make distcheck".

Ben Pfaff <blp>
Project Administrator
Thu 14 Dec 2006 01:30:54 AM UTC, comment #4: 

Your patch didn't pass makedist for me, and threw up lots of warnings in the gui directories.

I have a counter proposal.  Let's make src/language and subdirs into one big library, keeping the other libraries as they are.  src/language is the only one that IMO is less than optimally organised, and it's the only one that so far has caused problems.    I think it would be a backward step to conglomerate those parts of the code which are currently nicely seperated.

Patch attached.

(file #11518)

John Darrington <jmd>
Project Administrator
Wed 13 Dec 2006 04:23:03 AM UTC, comment #3: 

Here's a revised version that takes care of both of your suggestions.  I'm not so good with Automake so careful review is appreciated.

If anyone thinks a "+" in a library name is too obnoxious I'll change it to - or _.

I dropped the "private installation" bits because I doubt anyone else ever used them (they were never documented) and they incurred an Automake warning.

(file #11511)

Ben Pfaff <blp>
Project Administrator
Mon 11 Dec 2006 07:49:34 PM UTC, comment #2: 

I would like to keep math and its subdirectories as
libraries. It makes them easier to develop, debug and use
elsewhere. I don't think it would be too difficult to remove
the circular dependence between math linreg.

Jason H Stover <jstover>
Project Member
Mon 11 Dec 2006 10:20:37 AM UTC, comment #1: 

This will certainly stop us worrying about the dependencies.  The danger is they'll get forgotten about altogether.  If we end up implimenting a client/server arrangement or the Python plugin, then  we will have to go back to libraries again, and dependencies will once more become a big issue.

How about we compromise, and make the library domains coincide with the roles which are relatively stable and well understood:

One library containing src/libpspp and src/data.
Leave src/ui as loose objects.
src/ouput, src/language, src/math another library.

John Darrington <jmd>
Project Administrator
Mon 11 Dec 2006 02:51:37 AM UTC, original submission:  

This change set switches from building a library per directory to building no libraries in src and simply linking object files.  This lets us stop worrying so much about dependencies.

See pspp-dev discussion.

Ben Pfaff <blp>
Project Administrator

 

Attached Files
file #11518:  libs3.patch added by jmd (239KiB - application/octet-stream)
file #11511:  no-lib-2.patch added by blp (25KiB - text/x-patch - revised patch)
file #11503:  no-lib.patch added by blp (26KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jstover (Posted a comment)
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-14 jmd StatusNone => Done
        Assigned toblp => None
        Open/ClosedOpen => Closed
    2006-12-14 jmd Attached File- => Added libs3.patch, #11518
    2006-12-13 blp Attached File- => Added no-lib-2.patch, #11511
    2006-12-11 jmd Assigned tojmd => blp
    2006-12-11 blp Attached File- => Added no-lib.patch, #11503

    Back to the top


    Powered by Savane 3.5