patchPSPP - Patches: patch #5631, Clean up and improve...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5631: Clean up and improve sys-file-reader

Submitted by:  Ben Pfaff <blp>
Submitted on:  Sun 10 Dec 2006 10:33:36 PM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  Ben Pfaff <blp>
Open/Closed:  Closed

Mon 11 Dec 2006 12:37:06 PM UTC, comment #1: 

I had a look at this, and ran a few tests of my own, and couldn't see any problems.

John Darrington <jmd>
Project Administrator
Sun 10 Dec 2006 10:33:36 PM UTC, original submission:  

Clean up and rewrite sys-file-reader.  The rewritten version is simpler
and better abstracted, and should be easier to maintain and extend.
It avoids using structures to read file data, which is prone to
padding variations among compilers.  It should also handle non-IEEE
754 system files, although I haven't been able to find any.  It has
been tested against many .sav files obtained from the Web and found to
produce the same results as the earlier version of the code, or in
some cases improved results.  It is more tolerant of format variations
found in the wild.

Ben Pfaff <blp>
Project AdministratorIn charge of this item.

 

Attached Files
file #11501:  sys-file-reader.patch added by blp (117KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jmd (Posted a comment)
  • -email is unavailable- added by blp (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-11 blp StatusNone => Done
        Open/ClosedOpen => Closed
    2006-12-11 jmd Assigned tojmd => blp
    2006-12-10 blp Attached File- => Added sys-file-reader.patch, #11501

    Back to the top


    Powered by Savane 3.5