patchGNU TeXmacs - Patches: patch #5601, Fix for Bibtex plugin when paths...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5601: Fix for Bibtex plugin when paths have spaces/quotes/dollars in them

Submitted by:  Tom Hinton <hinton>
Submitted on:  Wed 29 Nov 2006 06:06:21 PM UTC  
 
Category:  Plugins Action:  Apply
Privacy:  Public Assigned to:  Denis Raux <denisraux>
Open/Closed:  Open Release:  current
Fixed Release:  Stable: 

Wed 29 Nov 2006 06:06:21 PM UTC, original submission:

When there are space in the path to a texmacs document the Bibtex plugin invokes bibtex without quoting or escaping the path, so this breaks texmacs files contained in directories with spaces in their names (or bibliography files in similar places).

Patch fixes this by
(a) quoting the strings passed to system and
(b) escaping quotes and $ within said strings

In theory I guess this fixes a security flaw as well, in that a malicious texmacs document could specify a bibliography file path
"/some/path; rm -rf /" or whatever, and then bibliography updates would go badly.

The substring replace code in the Classes/Atomic/string is fairly awful, for which I apologise. This patch is fit only for my purposes which don't include optimality on the small scale.

Tom Hinton <hinton>

 

Attached Files
file #11404:  spaces.patch added by hinton (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by vdhoeven (Updated the item)
  • -email is unavailable- added by hinton (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-03-03 vdhoeven Assigned toNone => denisraux
    2006-11-29 hinton Attached File- => Added spaces.patch, #11404

    Back to the top


    Powered by Savane 3.3