PSPP - Patches: patch #5561, Connect debugger on error
You are not allowed to post comments on this tracker with your current authentication level.
patch #5561: Connect debugger on error
Submitter: | John Darrington <jmd> | ||
Submitted: | Thu 16 Nov 2006 12:33:49 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | jmd |
Open/Closed: | Closed |
Thu 16 Nov 2006 03:38:25 AM UTC, comment #1: |
Ben Pfaff <blp> |
Thu 16 Nov 2006 12:33:49 AM UTC, original submission:
Do people think this patch will be generally useful?
|
John Darrington <jmd> |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
CC list is empty
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-11-16 | jmd | Status | Works For Me | Done | |
Open/Closed | Open | Closed | |||
2006-11-16 | blp | Status | Ready For Test/Review | Works For Me | |
Assigned to | None | jmd | |||
2006-11-16 | jmd | Attached File | - | Added debugger.patch, #11283 |
Powered by Savane 3.13-0329.
Corresponding source code
I am intrigued. This is interesting. It is also fairly simple and clean. It'd be fine with me if you committed it.
In connect_debugger: perror already adds a colon to the string, so you don't need one of your own in its argument. Could you use execlp("gdb", ...) to find gdb in $PATH, instead of specifying /usr/bin explicitly?
I'd tend to argue that, if fork or exec fails, we should return from connect_debugger and report the error in the usual manner, so that in bug_handler the new code would just be #if DEBUGGING/connect_debugger();/#endif
In debugger.h, the "G" is tripled in DEBUGGGER_H.