patchPSPP - Patches: patch #5522, Rewrite data_out and add thorough...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5522: Rewrite data_out and add thorough tests

Submitter:  Ben Pfaff <blp>
Submitted:  Sun 05 Nov 2006 12:30:40 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  blp
Open/Closed:  Closed

Sun 05 Nov 2006 05:21:06 AM UTC, comment #3: 

Checked in.

Ben Pfaff <blp>
Group administrator
Sun 05 Nov 2006 05:15:15 AM UTC, comment #2: 

Good point: I hadn't considered dates outside the expected range.  Just now I checked what SPSS does and the version that I'm about to check in will behave the same way it does (which is relatively weird).

Ben Pfaff <blp>
Group administrator
Sun 05 Nov 2006 02:39:28 AM UTC, comment #1: 

I can't see any problems here.  Does it behave sensibly if one specifies a date with a year of zero?

John Darrington <jmd>
Group administrator
Sun 05 Nov 2006 12:30:40 AM UTC, original submission:  

This rewrite of data_out makes its output conform closely to the output that SPSS produces.  It also adds numerous tests that make sure regressions don't occur.

A few test files were very large without compression, so they are not included in the patch.  They are attached separately in a .tar.gz file.  The .tar.gz also includes a clean copy of the rewritten src/data/data-out.c, which is difficult to read in the patch format.

Ben Pfaff <blp>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #11161:  data-out.tar.gz added by blp (210KiB - application/gzip - tarfile)
file #11160:  data-out.patch added by blp (431KiB - text/x-patch - patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-11-05 blp StatusReady For Test/Review Done
    Open/ClosedOpen Closed
2006-11-05 jmd Assigned tojmd blp
2006-11-05 blp StatusNone Ready For Test/Review
    Attached File- Added data-out.tar.gz, #11161
2006-11-05 blp Attached File- Added data-out.patch, #11160

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code