PSPP - Patches: patch #5511, Clean up variable formats
You are not allowed to post comments on this tracker with your current authentication level.
patch #5511: Clean up variable formats
Submitter: | Ben Pfaff <blp> | ||
Submitted: | Wed 01 Nov 2006 04:20:36 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | blp |
Open/Closed: | Closed |
Fri 03 Nov 2006 04:53:51 AM UTC, comment #2: |
Ben Pfaff <blp> |
Fri 03 Nov 2006 03:34:23 AM UTC, comment #1: I can't see any major issues. Some minor ones:
|
John Darrington <jmd> |
Wed 01 Nov 2006 04:20:36 AM UTC, original submission:
This change set cleans up src/data/format.[ch] and deals with the direct fallout. It will be followed up by a change set that fixes data_out and adds a thorough collection of tests to prevent regressions, then by a change set that does similarly for data_in.
|
Ben Pfaff <blp> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-11-03 | blp | Status | Ready For Test/Review | Done | |
Open/Closed | Open | Closed | |||
2006-11-03 | jmd | Assigned to | jmd | blp | |
2006-11-01 | blp | Attached File | - | Added format.tar.gz, #11125 | |
2006-11-01 | blp | Attached File | - | Added format.patch, #11124 |
Powered by Savane 3.13-02a9.
Corresponding source code
Thank you for the comments.
These comments don't make it to the compiler. They get dropped by the Perl code that translates operations.def into various C source files.
Good spotting! Fixed.
We could do something like that, sure. Would it make sense to generalize it, to make a function that returns a "picture" of what a format outputs, for any given format?
SPSS disallows using custom currency formats for input. I think that's probably due to ambiguity issues. I wasn't planning to change it; it doesn't seem too useful, and we'd have to define the semantics of what it means.