PSPP - Patches: patch #5466, Encapsulated procedure.c
You are not allowed to post comments on this tracker with your current authentication level.
patch #5466: Encapsulated procedure.c
Submitter: | John Darrington <jmd> | ||
Submitted: | Thu 19 Oct 2006 10:53:32 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Thu 19 Oct 2006 02:03:24 PM UTC, comment #1: |
Ben Pfaff <blp> |
Thu 19 Oct 2006 10:53:32 AM UTC, original submission:
I'm proposing this patch.
|
John Darrington <jmd> |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
CC list is empty
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-10-19 | jmd | Status | Ready For Test/Review | Done | |
Open/Closed | Open | Closed | |||
2006-10-19 | jmd | Attached File | - | Added dataset.patch, #11004 |
Powered by Savane 3.13-bb6a.
Corresponding source code
This is clearly an improvement. It looks good. Thank you for writing it. If it passes "make check", please check it in.
I'm not actually sure it makes the DATASET stuff easier, though. I thought I had concluded that those commands were essentially equivalent to PSPP scratch files (which I think we should drop once the DATASET commands are working). But this is a good change whether it affects DATASET or not.
In procedure.c, the comma below should be a semicolon:
@@ -504,8 +518,9 @@
split_aux.proc_func = proc_func;
split_aux.end_func = end_func;
split_aux.func_aux = func_aux;
+ split_aux.dataset = ds,