patchphpGroupWare - Patches: patch #5433, Addressbook times out under PHP5

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5433: Addressbook times out under PHP5

Submitter:  Steve Price <steep>
Submitted:  Sun 01 Oct 2006 08:00:56 PM UTC
   
 
Category:  addressbook Priority:  5 - Normal
Item Group:  SVN trunk (dev code) Status:  Done
Privacy:  Public Assigned to:  skwashd
Open/Closed:  Closed

Tue 24 Oct 2006 01:50:16 PM UTC, comment #2: 

I have also applied this to stable now.  Sorry for the delay, I have been rather focussed on HEAD atm.

Dave Hall <skwashd>
Group administrator
Mon 02 Oct 2006 12:34:49 AM UTC, comment #1: 

Thanks for that.  It has been committed to cvs.  The patch is appreciated.  I have also changed the each to a foreach in HEAD recently.

Dave Hall <skwashd>
Group administrator
Sun 01 Oct 2006 08:00:56 PM UTC, original submission:  

Target Branch: HEAD
Purpose: Under PHP5, the addressbook times out / doesn't show any
entries. This is caused by the '@' on the each() on line 464 of uiaddressbook, so the array doesn't increment.
Also, contacts_sql has 3 array_merge() which need the 2nd arg casting to array (due to the change of operation under PHP5)
Format: cvs rcs || diff
Affected file/s:
  addressbook/inc/class.uiaddressbook.inc.php,
  phpgwapi/inc/class.contacts_sql.inc.php

Steve Price <steep>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10875:  addressbook.diff added by steep (2KiB - application/octet-stream - run 'patch -p1 < addressbook.diff' in phpgroupware dir)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-02 skwashd StatusIn Progress Done
    Open/ClosedOpen Closed
2006-10-02 skwashd StatusNone In Progress
    Assigned toNone skwashd
2006-10-01 steep Attached File- Added addressbook.diff, #10875

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code