patchphpGroupWare - Patches: patch #5374, Add SSO to phpgroupware

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5374: Add SSO to phpgroupware

Submitter:  Caeies <Caeies>
Submitted:  Wed 06 Sep 2006 02:25:10 PM UTC
   
 
Category:  API - phpGWapi Priority:  7 - High
Item Group:  SVN trunk (dev code) Status:  Done
Privacy:  Public Assigned to:  Caeies
Open/Closed:  Closed

Tue 19 Sep 2006 11:45:31 AM UTC, comment #2: 

Hi all

> * why is chdir used before include_once ? Just use include_once with the right path


The main problem is that if we do that, we broke all the login stuff ... at least on our version of php + phpgroupware.

> * I would like to see the prefs code be OOP'd and using XSLT, as it isn't in the API this can be done later.


Work in progress :)

> * The phpdocs could do with a bit more work, especially the method arguments :)


Clearly.

> * The link on the login screen, can that be a template block, so it is only shown when SSO is enabled ?


I was thinking that it was already the case. I perhaps forgot something somewhere :)

> * the css class "button_group" is for groups of buttons, not links.
> * All new templates in HEAD should use CSS not hard coded html attributes such as bgcolor and other ugly things


So we create a new class like link_group ? in the base css ? I guess that most of this comes from phpgw .16 and that's why ugly things are in :)

We will try to be as quick as possible.

Regards.

Caeies



Caeies <Caeies>
Group administrator
Sun 17 Sep 2006 01:20:31 AM UTC, comment #1: 

Hi guys,

I have looked over this, and in general I support it.

Here are my initial comments:

  • why is chdir used before include_once ?  Just use include_once with the right path


  • I would like to see the prefs code be OOP'd and using XSLT, as it isn't in the API this can be done later.


  • The phpdocs could do with a bit more work, especially the method arguments :)


  • The link on the login screen, can that be a template block, so it is only shown when SSO is enabled ?


  • the css class "button_group" is for groups of buttons, not links.


  • All new templates in HEAD should use CSS not hard coded html attributes such as bgcolor and other ugly things


I know it has taken me a while to get back to you about this, but things have been a little crazy.

I am willing to hold the tech preview release while you make the above changes, if you want this code included in 0.9.18

Dave Hall <skwashd>
Group administrator
Wed 06 Sep 2006 02:25:10 PM UTC, original submission:  

Hi all,

This patch, for HEAD does following things :

 - Add phpgwapi/inc/mapping directory
 - Add phpgwapi/inc/sso directory
 - Add phpgwapi/inc/auth/class.auth_remoteuser.inc.php auth method
 - Modify heavily login.php, to use a special function for display so, being reusable by other files in sso/
 - Add a preferences/mapping.php file to let people managing their own mapping.

The purpose of this modifications is to permit full use of CAS / Shibboleth in phpgroupware. We use a mapping between REMOTE_USER variables and phpgw accounts, thus disturbing as fiew as possible the existing code.
We allow the use of a partial use of REMOTE_USER to help the migration.

More infos will be integrated asasp in a README, explaining the whole process.

Feel free to ask question.

Cheers,

Vu & Caeies.

Caeies <Caeies>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10701:  include_shibboleth.tgz added by Caeies (13KiB - application/x-gtar - For validation)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-10-18 Caeies StatusReady For Test Done
    Open/ClosedOpen Closed
2006-09-17 skwashd Assigned toNone Caeies
2006-09-06 Caeies StatusNone Ready For Test
2006-09-06 Caeies Attached File- Added include_shibboleth.tgz, #10701
    Carbon-Copy- Added -email is unavailable-

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code