bugGNU Screen - Bugs: bug #35277, gcc -Wall found some serious bugs...

 
 

bug #35277: gcc -Wall found some serious bugs in the source code

Submitter:  None
Submitted:  Tue 10 Jan 2012 01:20:39 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  * 5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  Cur Dev Sources
Fixed Release:  None Planned Release:  None
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 03 Jun 2015 03:17:53 PM UTC, comment #2: 

CLOSED

Alexander Naumov <anaumov>
Group administrator
Mon 27 Feb 2012 01:31:57 PM UTC, comment #1: 

Please mark this bug as closed.

amade's patch from 27/01/2012 (Subject in screen-devel: -Wall warnings fixes patch) fixed it.

Regards, Tim

Tim Ruehsen <rockdaboot>
Tue 10 Jan 2012 01:20:39 PM UTC, original submission:  

I just compiled screen (4.1.0 20110819) with gcc -Wall and discovered some issues:

1. ansi.c / DoCSI()

  curr->w_charsets[0] = curr->w_charsets[1] =
    curr->w_charsets[2] = curr->w_charsets[2] =
    curr->w_FontL = curr->w_FontR = ASCII;

IMHO should be


  curr->w_charsets[0] = curr->w_charsets[1] =
    curr->w_charsets[2] = curr->w_charsets[3] =
    curr->w_FontL = curr->w_FontR = ASCII;

2. mark.c / nextchar()
local variable 'step' isn't initialized for case 't' and 'T'.
this could lead from infinite loop to random behaviour.

3. window.c / RemakeWindow()
the local variable 'f'  isn't initialized if BUILDIN_TELNET is defined.
this could result in read from / write into a random file descriptor.

4. list_display.c / gl_Display_footer()
the function does not have a return statement, resulting in always returning 0. this prevents gl_Display_rebuild(ldata) being called.

5. list_window.c / gl_Window_input()
return should return a value here:
      if (display && AclCheckPermWin(D_user, ACL_READ, win))
return; /* Not allowed to switch to this window. */


Thanks for listening.

Tim Ruehsen

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by anaumov (Posted a comment)
  • -email is unavailable- added by rockdaboot (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-06-03 anaumov StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-cf05.
    Corresponding source code