bugmake - Bugs: bug #13551, type casts on left value in...

 
 

bug #13551: type casts on left value in sub_proc.c

Submitter:  Jerker Bäck <jerker_back>
Submitted:  Sun 26 Jun 2005 03:59:40 PM UTC
   
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  psmith Open/Closed:  Closed
Component Version:  4.0 Operating System:  MS Windows
Fixed Release:  3.81 Triage Status:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 26 Jun 2005 03:59:40 PM UTC, original submission:  

make\w32\subproc\sub_proc.c(539) : warning C4213: nonstandard extension used : cast on l-value
it looks like this:
-----------------------------------------
if (pproc->sv_stdin) {
CloseHandle((HANDLE)pproc->sv_stdin[1]);
(HANDLE)pproc->sv_stdin[1] = 0;
}
-----------------------------------------
HANDLE is of type (void*) and should be either NULL or point to a valid created Win32-object (ie a file-handle).

change to:
-----------------------------------------
if (pproc->sv_stdin) {
CloseHandle((HANDLE)pproc->sv_stdin[1]);
pproc->sv_stdin[1] = 0;
}
-----------------------------------------
same at:
make\w32\subproc\sub_proc.c(539)
make\w32\subproc\sub_proc.c(543)
make\w32\subproc\sub_proc.c(547)
make\w32\subproc\sub_proc.c(677)
make\w32\subproc\sub_proc.c(742)
make\w32\subproc\sub_proc.c(750)
make\w32\subproc\sub_proc.c(758)

in resonse to:
make\w32\subproc\sub_proc.c(783) : warning C4701: local variable 'tStdin' may be used without having been initialized

change:
sub_proc.c(661)
HANDLE tStdin, tStdout, tStderr;
to
HANDLE tStdin = NULL, tStdout = NULL, tStderr = NULL;



Jerker Bäck <jerker_back>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-04-01 psmith Fixed Release4.0 3.81
2005-06-27 psmith StatusNone Fixed
    Assigned toNone psmith
    Open/ClosedOpen Closed
    Fixed ReleaseNone 4.0

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code