GNU GRUB - Bugs: bug #31679, grub-mkconfig fails to add...
You are not allowed to post comments on this tracker with your current authentication level.
bug #31679: grub-mkconfig fails to add 40_custom correctly if last line has no line-feed
Submitter: | Barry Jackson <barjac> | ||
Submitted: | Tue 16 Nov 2010 11:35:46 PM UTC | ||
Category: | Configuration | Severity: | Major |
Priority: | 5 - Normal | Item Group: | Software Error |
Status: | Invalid | Privacy: | Public |
Assigned to: | None | Originator Name: | Barry Jackson |
Open/Closed: | Closed | Release: | Bazaar - trunk |
Release: | Reproducibility: | Every Time | |
Planned Release: | None |
Wed 17 Nov 2010 01:22:15 PM UTC, comment #2: |
Barry Jackson <barjac> |
Wed 17 Nov 2010 07:22:35 AM UTC, comment #1: configuration file without a \n at the end is invalid. 40_custom doesn't have to be able to parse invalid files. |
Vladimir Serbinenko <phcoder> |
Tue 16 Nov 2010 11:35:46 PM UTC, original submission:
If the last line in 40_custom has no line-feed, then grub-mkconfig appends the 40_custom section footer to the end of the line breaking the command.
|
Barry Jackson <barjac> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2010-11-17 | phcoder | Status | None | Invalid | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-758e.
Corresponding source code
It may be invalid, but how is the average user to know that?
All I did was to stop typing without hitting return at the end of the last line.
This can be fixed with one "echo", so why leave it potentially broken?
--- grub/util/grub-mkconfig.in~ 2010-11-17 13:04:07.000000000 +0000
+++ grub/util/grub-mkconfig.in 2010-11-17 13:04:04.000000000 +0000
@@ -285,6 +285,7 @@
echo
echo "### BEGIN $i ###"
"$i"
+ echo
echo "### END $i ###"
fi
;;