bugGNU GRUB - Bugs: bug #31679, grub-mkconfig fails to add...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #31679: grub-mkconfig fails to add 40_custom correctly if last line has no line-feed

Submitted by:  Barry Jackson <barjac>
Submitted on:  Tue 16 Nov 2010 11:35:46 PM UTC
 
Category:  Configuration Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  Invalid Privacy:  Public
Assigned to:  None Originator Name:  Barry Jackson
Open/Closed:  Closed Release: 
Release:  * Bazaar - trunk Reproducibility:  Every Time
Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Wed 17 Nov 2010 01:22:15 PM UTC, comment #2: 

It may be invalid, but how is the average user to know that?
All I did was to stop typing without hitting return at the end of the last line.
This can be fixed with one "echo", so why leave it potentially broken?

--- grub/util/grub-mkconfig.in~ 2010-11-17 13:04:07.000000000 +0000
+++ grub/util/grub-mkconfig.in  2010-11-17 13:04:04.000000000 +0000
@@ -285,6 +285,7 @@
         echo
         echo "### BEGIN $i ###"
         "$i"
+        echo
         echo "### END $i ###"
       fi
     ;;

Barry Jackson <barjac>
Wed 17 Nov 2010 07:22:35 AM UTC, comment #1: 

configuration file without a \n at the end is invalid. 40_custom doesn't have to be able to parse invalid files.

Vladimir Serbinenko <phcoder>
Project Administrator
Tue 16 Nov 2010 11:35:46 PM UTC, original submission:  

If the last line in 40_custom has no line-feed, then grub-mkconfig appends the 40_custom section footer to the end of the line breaking the command.

Example:-
set menu_color_highlight=yellow/blue### END /etc/grub.d/40_custom ###

Barry Jackson <barjac>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by barjac (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-11-17 phcoder StatusNone => Invalid
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.9