bugGNU GRUB - Bugs: bug #30364, ...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #30364: grub-mkconfig(/etc/grub.d/10_linux) ignores builtin initrds

Submitted by:  Dennis Schridde <devurandom>
Submitted on:  Tue 06 Jul 2010 06:24:58 AM UTC
 
Category:  Configuration Severity:  Major
Priority:  5 - Normal Item Group:  Software Error
Status:  Fixed Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Closed Release: 
Release:  * 1.98 Reproducibility:  Every Time
Planned Release:  None
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       

 

Mon 01 Nov 2010 11:54:22 AM UTC, comment #2: 

Issue is likely to be fixed in mainline and original reporter failed to answer retest request. Closing. If it still persists feel fre to reopen

Vladimir Serbinenko <phcoder>
Project Administrator
Mon 18 Oct 2010 01:45:52 PM UTC, comment #1: 

Your patch doesn't take care of all version formats supported and is really not checking if CONFIG_INITRAMFS_SOURCE is empty or not.

I have fixed this issue in mainline with different patch, can you test it and confirm?

BVK Chaitanya <bvk>
Project Member
Tue 06 Jul 2010 06:24:58 AM UTC, original submission:  

When CONFIG_INITRAMFS_SOURCE is set, no seperate initrd is necessary.
grub-mkconfig from grub-1.98 (specifically /etc/grub.d/10_linux)
ignores this and assumes:
"""
# "UUID=" magic is parsed by initrds.  Since there's no initrd, it can't work
here
"""

I propose following fix:
--- /etc/grub.d/10_linux.orig   2010-06-28 14:22:06.080669780 +0200
+++ /etc/grub.d/10_linux        2010-06-28 14:21:24.177670182 +0200
@@ -128,7 +128,7 @@
   done
   if test -n "${initrd}" ; then
     echo "Found initrd image: ${dirname}/${initrd}" >&2
-  else
+  elif ! grep "CONFIG_INITRAMFS_SOURCE=" /boot/config-${version} 2> /dev/null
; then
     # "UUID=" magic is parsed by initrds.  Since there's no initrd, it can't
work here.
     linux_root_device_thisversion=${GRUB_DEVICE}

Dennis Schridde <devurandom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by bvk (Posted a comment)
  • -email is unavailable- added by devurandom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-11-01 phcoder StatusNone => Fixed
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.9