bugGNUstep - Bugs: bug #13383, missing path in openbsd build

Group
 
 

bug #13383: missing path in openbsd build

Submitter:  Riccardo Mottola <rmottola>
Submitted:  Sun 12 Jun 2005 08:59:25 PM UTC
   
 
Category:  Gui/AppKit Severity:  3 - Normal
Item Group:  Bug Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 17 Feb 2009 12:26:33 AM UTC, comment #8: 

Being worked on as #25602

Thanks

Nicola Pero <nico>
Group Member
Mon 19 Mar 2007 01:42:51 AM UTC, comment #7: 

Actually there is already a pkg.m4 file in back that implements an autoconf macro for checking packages via pkg-config. That should probably just be copied to gui so that you can check for png.  Look at the back/configure.ac for example usage.

Adam Fedor <fedor>
Group administrator
Sun 18 Mar 2007 01:00:50 PM UTC, comment #6: 

Interesting... not what I would have expected, but it seems that this will be 'fixed' in future versions of OpenBSD proper.

Thank you for checking!

I still think we should be using pkg-config /if/ it is available to determine the build flags.

Nicola, what do you think?
And if you agree, do you agree that a "global" check for pkg-config should go into -make?
And should the result be cached somewhere to be included by -gui's configure?

David Ayers <ayers>
Group Member
Sun 18 Mar 2007 11:30:35 AM UTC, comment #5: 

the Makefile in the OpenBSD ports has no BUILD_DEPENDS, LIB_DEPENDS, or RUN_DEPENDS, defined, therefore it is installed without the need for pkg-config

Sebastian Reitenbach <buzzdee>
Group Member
Sun 18 Mar 2007 10:26:25 AM UTC, comment #4: 

IMHO, I think we should check for the availability of pkg-config and try to use it if available, as that seems to be the tool they are suppling to solve this issue.

What I'm not sure about is whether:
- the availablity of pkg-config should be checked once in -make's configure
- stored by make in some file that can be ...
- ... included by -gui's configure which will then specifcally check for libpng

or have everything checked in -gui's configure

But I'm still wondering... how is the developer package of libpng installed on OpenBSD (currently)?  Shouldn't it depend on pkg-config and couldn't we therefor assume that if the developer package of libpng is installed properly that pkg-config is also installed?  That would be my expectation...

David Ayers <ayers>
Group Member
Sat 17 Mar 2007 05:20:55 PM UTC, comment #3: 

the upcoming OpenBSD 4.1 release will come with a bsd licensed pkg-config. Up to that release, the gnu version has to be used from ports/packages.

with pkgconfig-0.19p0.tgz, installed package on OpenBSD 4.0:

 pkg-config --cflags --libs libpng
-I/usr/local/include/libpng  -L/usr/local/lib -lpng -lz -lm

Sebastian Reitenbach <buzzdee>
Group Member
Sat 17 Mar 2007 04:56:41 PM UTC, comment #2: 

Just for kicks I ran:

pkg-config --cflags --libs libpng

and voila:

-I/usr/include/libpng12  -lpng12

does that also work on OpenBSD?

David Ayers <ayers>
Group Member
Sat 17 Mar 2007 04:14:22 PM UTC, comment #1: 

Is this still an issue ?

How do we decide when/if to add

 -I/usr/local/include/libpng

to the compile line ?

Thanks

Nicola Pero <nico>
Group Member
Sun 12 Jun 2005 08:59:25 PM UTC, original submission:  

when building openbsd, the default place where libpng headers reside (when installed using the ports) is not included:

 Compiling file NSBitmapImageRep+PNG.m ...
NSBitmapImageRep+PNG.m:34: png.h: No such file or directory
gmake[2]: * [shared_obj/NSBitmapImageRep+PNG.o] Error 1
g

the directory to include is:

ls /usr/local/include/libpng
png.h     pngconf.h

I added
ADDITIONAL_INCLUDE_DIRS +=    -I/usr/local/include/libpng
to config.make

Riccardo Mottola <rmottola>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by fedor (Posted a comment)
  • -email is unavailable- added by buzzdee (Posted a comment)
  • -email is unavailable- added by ayers (Posted a comment)
  • -email is unavailable- added by nico (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-02-17 nico Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code