bugGNUstep - Bugs: bug #13305, potentially severe move of source...

Group
 
 

bug #13305: potentially severe move of source directory during "make dist"

Submitter:  Wolfgang Sourdeau <wolfgang>
Submitted:  Sun 05 Jun 2005 08:20:44 PM UTC
   
 
Category:  Makefiles Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  fedor
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 10 Jun 2005 04:07:05 PM UTC, comment #1: 

I fixed this by making a tar/copy of the directory rather than moving it.

Adam Fedor <fedor>
Group administrator
Sun 05 Jun 2005 08:20:44 PM UTC, original submission:  

In $MAKEFILES/Master/source-distribution.make, the act of "make dist" temporarily renames the source directory. This is wrong by any good practice "manual".
First, because a program could be running inside of that directory and try to access a file which would then be made unavailable. Second, if you interrupt that step, you can be left with your directory not being renamed back.
What is considered good practice is to not interfere with the user's environment at all.

As posted in <20050605182916.GA32281@Contre.COM>, this can lead to serious loss in programming hours due to the programmer considering its environment to be sane...

Wolfgang Sourdeau <wolfgang>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-06-10 fedor StatusNone Fixed
    Assigned toNone fedor
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code