bugGNUstep - Bugs: bug #13175, [NSTask launch] doen't work on...

Group
 
 

bug #13175: [NSTask launch] doen't work on Windows

Submitter:  None
Submitted:  Tue 24 May 2005 04:03:07 PM UTC
   
 
Category:  Base/Foundation Severity:  3 - Normal
Item Group:  Bug Status:  Fixed
Privacy:  Public Assigned to:  CaS
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 07 Jul 2005 09:35:29 AM UTC, comment #3: 

Seems to be ok now.

Richard Frith-Macdonald <CaS>
Group Member
Thu 07 Jul 2005 09:06:55 AM UTC, comment #2: 

They work for me on a productive system.

Thanks
Marc

Anonymous
Sat 04 Jun 2005 09:11:42 AM UTC, comment #1: 

I've made the suggested changes in CVS ... please let me know if they work for you.

Richard Frith-Macdonald <CaS>
Group Member
Tue 24 May 2005 04:03:07 PM UTC, original submission:  

Hi,

Here are 2 snippets out of NSTask.m

[snip]
/**

  • Returns the standard input stream for the task - an NSFileHandle
  • unless an NSPipe was passed to -setStandardInput:

 */
- (id) standardInput

[/snap]


[snip out of [NSConcreteWindowsTask launch]]
  start_info.hStdInput = [[self standardInput] nativeHandle];
[/snap]

This, of couse, doesn't work. There's no [NSPipe nativeHandle] method.

Patch should look somehow like this (take a look at [NSConcreteUnixTask launch]):

  if ([hdl isKindOfClass: [NSPipe class]])
    {
      hdl = [hdl fileHandleForReading];
// make sure to close close it
    }
 
  start_info.hStdInput = [hdl nativeHandle];


regards
Marc

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-07 CaS StatusNone Fixed
    Open/ClosedIn Test Closed
2005-06-04 CaS Open/ClosedOpen In Test
2005-06-04 CaS Assigned toNone CaS

Back to the top

Powered by Savane 3.13-758e.
Corresponding source code