<bjohnson> in contacts_sql:
<bjohnson> function get_sub_cats($cat_id)
<bjohnson>                 {
<bjohnson>                         $sql = 'SELECT cat2.cat_id FROM phpgw_categories as cat '
<bjohnson>                                 .'INNER JOIN phpgw_categories as cat2 ON cat.cat_id=cat2.cat_parent '
<bjohnson>                                 .'WHERE '.sql::in('cat.cat_id', $cat_id);
<bjohnson> THAT ^^ only gets one level of sub cats down .. NOT ALL SUB-CATS
<bjohnson> it matches how the categories class does it .. which imo should be modified
<jarg> see more below :P

<bjohnson> yes .. that then goes down one more level correct
<jarg> this function is recursive
<bjohnson> why does ab make it's own function instead of using class.categories?
<jarg> because modify categories is more work :P


<bjohnson> for me, that is picking up 6 cat_id's when it should be 9
<bjohnson> when I select a first level cat that has sub-cats who in turn have sub-cats, only the sub-sub-cats (the third) level is returned
<bjohnson> I haven't checked with more than three levels but I suspect only the last level is returned
<bjohnson> can return even be used this way?

<bjohnson> one other funny thing.  I can't find where get_sub_cats is ever called from uiaddressbook

Notice that this has been moved to phpgwapi bug reports. 

1. The addressbook should be checked (please give specifics of tests)

2. The categories class should be modified to do recursive sub-cats (I think that is the logic behind it's intent)

3. The addressbook should use the categories class.

Don't close this, but it is more than just addressbook. 

I think the entire categories class has trouble with anything more than a two level cat system.  For instance, the nextmatch category filters will not include the records from a third level (or below) sub cat

It sounds like the entire concept of the category system will be under review within the next year and this items should be addressed in that revision.

I am moving it from addressbook to the phpgwapi and reassigning to who might be working on category code in the near future.

mm, this works fine for my, you try with mysql or postgres?

Is this in the edit form or in the plain view. If its the later then state the template and test for idots and probiz, cause its working here. If its the former, well then its also weird cause i see it just fine here.