bugDenemo - Bugs: bug #65256, Compile error in...

 
 

bug #65256: Compile error in src/source/proof.c pointer mismatch

Submitter:  Roy Rankin <rrankin>
Submitted:  Mon 05 Feb 2024 05:50:28 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 05 Feb 2024 02:55:47 PM UTC, comment #1: 

Line 280 seems to have moved since the version you are quoting, but it seems that there was a header file missing - at line 24 there is currently

#ifdef USE_ATRIL
#include <atril-view.h>
#include <atril-document.h>
#else
#include <evince-view.h>
#include <evince-document.h>
#endif

it seems the non USE_ATRIL build should have

#include "ev-document-annotations.h"

as well (this is implied by
https://evince-doc.github.io/ev-document-annotations_8c.html
which I'm guessing is the up-to-date docs)
However, it would be best to set USE_ATRIL in the configure step as the Evince libraries don't support clicking on links in the Print View in Denemo as they used to and so this feature - proofreading - won't be working anyway when building with current Evince libraries.
The USE_ATRIL build does not issue a warning - the ev-document-annotations.h is included in atril-document.h it seems.






Richard Shann <rshann>
Group administrator
Mon 05 Feb 2024 05:50:28 AM UTC, original submission:  

Fedora package compile sets pointer mismatch to an error in f40 where previously it was a warning. This causes the Fedora package build to fail.
The issue is in src/source/proof.c lines 280 and 316.
The first argument of ev_document_annotations_get_annotations should be type "EvDocumentAnnotations " but is type "EvDocument ".

I have not worked out how to correct this issue or even how the code is invoked. My workaround is to add a cast, but this can not possible be the correct solution.

Roy Rankin <rrankin>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by rrankin (Submitted the item)
  • -email is unavailable- added by rrankin
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-02-05 rrankin Carbon-Copy- Added rrankin

    Back to the top

    Powered by Savane 3.13-8ccc.
    Corresponding source code