bugGNU gettext - Bugs: bug #63529, xgettext: potential null-ptr...


You are not allowed to post comments on this tracker with your current authentication level.

bug #63529: xgettext: potential null-ptr dereference in XML resource locating rules

Submitter:  Shashank <theshank>
Submitted:  Thu 15 Dec 2022 12:58:35 AM UTC
Category:  XML Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  ueno
Open/Closed:  Closed

Sun 05 Mar 2023 01:53:41 AM UTC, comment #2: 
Daiki Ueno <ueno>
Project Administrator
Thu 15 Dec 2022 02:42:22 AM UTC, comment #1: 

This code gets only used when parsing .loc files, indicated through command-line options and/or environment variables to the msgfmt and xgettext programs.

The .loc files shipped with gettext apparently have the "target" or "pattern" attributes where expected.

Still, I agree that the code could be made more robust.

Bruno Haible <haible>
Project Administrator
Thu 15 Dec 2022 12:58:35 AM UTC, original submission:  

In gettext-tools/src/locating-rule.c, the following code does not check the return value of xmlGetProp, which would lead to NULL-pointer dereference in xstrdup() (in gettext-tools/gnulib-lib/xstrdup.c) whenever xmlGetProp() returns NULL.

static char *
get_attribute (xmlNode *node, const char *attr)
  xmlChar *value;
  char *result;

  value = xmlGetProp (node, BAD_CAST attr);
  result = xstrdup ((const char *) value);
  xmlFree (value);

  return result;

Shashank <theshank>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by ueno (Posted a comment)
  • -email is unavailable- added by haible (Posted a comment)
  • -email is unavailable- added by theshank (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.




    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-03-05 ueno StatusConfirmed Fixed
        Assigned toNone ueno
        Open/ClosedOpen Closed
    2022-12-15 haible CategoryC XML
        StatusNone Confirmed

    Back to the top

    Powered by Savane 3.11