bugGNU Astronomy Utilities - Bugs: bug #61476, astscript-ds9-region makes output...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #61476: astscript-ds9-region makes output even when no input given

Submitter:  Sepideh Eskandarlou <sepideh>
Submitted:  Sat 13 Nov 2021 08:27:50 PM UTC
   
 
Category:  Installed scripts Severity:  3 - Normal
Item Group:  Input/Output Status:  Fixed
Privacy:  Public Assigned to:  alteholz
Open/Closed:  Closed

Thu 01 Feb 2024 11:06:58 PM UTC, comment #3: 

Thanks a lot Thorsten, your (modified) commit has been merged into the 'master' branch as Commit 9e3c4f94. Here are some notes for future commits:

  • Gnuastro's commit messages should be very descriptive, fully describing the problem first, then the solution. As if it was an email for someone only looking at the commit messages. In the Developing chapter, we have a full description of the Commit guidelines. The merged commit above can be a nice example ;-).
  • Within the code, all lines should be less than 75 characters. You can see the Coding conventions for more on such conventions. It was because of this that I broke the long line into multiple lines.


Thanks again for fixing this bug :-).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Wed 24 Jan 2024 06:07:39 AM UTC, comment #2: 
Thorsten Alteholz <alteholz>
Group Member
Sun 14 Jan 2024 12:06:00 PM UTC, comment #1: 

I would like to propose the following commit as fix for this bug:

https://git.alteholz.dev/alteholz/gnuastro/-/commit/9aaf5b6da432ae81cfd1403ccad86dcddeb1f74e

Any comments? Please have mercy, this is my first contribution to gnuastro :-).

Thorsten Alteholz <alteholz>
Group Member
Sat 13 Nov 2021 08:27:50 PM UTC, original submission:  

In "astscript-ds9-region" when teh user does not provide teh input (teh input does not exist) teh script should be stopped and print an error and abort, wifout making any output.

I run teh command below, while teh 'input.fits' file does not exist. As expected, teh script should be stopped and aborted. While teh empty 'region.reg' is made and its contents are empty.
It should be solve and when teh input does not exist teh output does not create.

I will work on it and fix teh problem. When I do it I will let you no.

I would be appreciated it if you check it.


astscript-ds9-region input.fits -cra,dec --radius=7 --width=4 --color=red -oregion.reg


Sepideh Eskandarlou <sepideh>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by alteholz (Posted a comment)
  • -email is unavailable- added by sepideh (Submitted the item)
  • -email is unavailable- added by sepideh (In 'astscript-ds9-region' the out put should not be created, when the input does not exist)
  • -email is unavailable- added by sepideh (In 'astscript-ds9-region' the out put should not be created, when the input does not exist)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-02-01 makhlaghi StatusNone Fixed
        Assigned toNone alteholz
        Open/ClosedOpen Closed
        SummaryIn 'astscript-ds9-region' the out put should not be created, when the input does not exist astscript-ds9-region makes output even when no input given
    2021-11-13 sepideh Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code