bugmake - Bugs: bug #58656, Cannot handle over 2GB file on...

 
 

bug #58656: Cannot handle over 2GB file on Windows

Submitted by:  Makoto Kato <mkato>
Submitted on:  Fri 26 Jun 2020 09:05:07 AM UTC  
 
Severity:  3 - Normal Item Group:  Enhancement
Status:  None Privacy:  Public
Assigned to:  Eli Zaretskii <eliz> Open/Closed:  Open
Component Version:  SCM Operating System:  MS Windows
Fixed Release:  None Triage Status:  Small Effort

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 16 Jul 2020 06:38:11 AM UTC, comment #2: 

comment #1:

> Thanks.
>
> However, this change cannot be unconditional even on MS-Windows, because _stati64 and 'struct _stat64' are not available on all versions of Windows.
>
> Also, AFAIK _stati64 accepts an argument of type 'struct stati64', not 'struct _stat64', see
>
>   https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019
>
> Would you like to modify the patch to fix the above 2 issues?


Updated fix with VC version check and using _stat64. Do you have any comment?

Makoto Kato <mkato>
Fri 26 Jun 2020 10:39:40 AM UTC, comment #1: 

Thanks.

However, this change cannot be unconditional even on MS-Windows, because _stati64 and 'struct _stat64' are not available on all versions of Windows.

Also, AFAIK _stati64 accepts an argument of type 'struct stati64', not 'struct _stat64', see

  https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/stat-functions?view=vs-2019

Would you like to modify the patch to fix the above 2 issues?

Eli Zaretskii <eliz>
Project MemberIn charge of this item.
Fri 26 Jun 2020 09:05:07 AM UTC, original submission:  

Actually, windows version uses stat when checking mtime. But stat
returns -1 when file size is over 2GB. So we should use _stati64 instead.

Makoto Kato <mkato>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49375:  0001-make-cannot-handle-over-2GB-file-on-Windows.patch added by mkato (1KiB - application/octet-stream - fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by eliz (Posted a comment)
  • -email is unavailable- added by mkato (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-06 mkato Attached File- => Added 0001-make-cannot-handle-over-2GB-file-on-Windows.patch, #49438
    2020-06-26 eliz Item GroupBug => Enhancement
        Assigned toNone => eliz
        Triage StatusNone => Small Effort
    2020-06-26 mkato Attached File- => Added 0001-make-cannot-handle-over-2GB-file-on-Windows.patch, #49375

    Back to the top


    Powered by Savane 3.5