bugLibreJS - Bugs: bug #58587, FSF donation page broken by...

 
 

bug #58587: FSF donation page broken by "CDATA"?

Submitter:  Andrew Engelbrecht <sudoman>
Submitted:  Tue 16 Jun 2020 09:01:22 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Need Info
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 01 May 2022 12:57:59 AM UTC, comment #3: 


comment #2:

> librejs appears to be working properly with '<!--//--><![CDATA[//><!--' on one of our dev servers.


Thanks for confirming.

Yuchen Pei <ycp>
Group administrator
Fri 29 Apr 2022 05:57:32 PM UTC, comment #2: 

librejs appears to be working properly with '<!--//--><![CDATA[//><!--' on one of our dev servers.

Andrew Engelbrecht <sudoman>
Mon 18 Apr 2022 01:17:02 PM UTC, comment #1: 


original submission:

> https://my.fsf.org/donate
>
> "CDATA" is sometimes necessary for XHTML code, but not HTML 5. Despite this, Drupal sometimes marks code with "CDATA" code.
>


> <script type="text/javascript">
> <!--//--><![CDATA[//><!--
> /**
>  * @licstart The following is the entire license notice for the JavaScript
>  * code in this page.
> ...
>  * @licend The above is the entire license notice for the JavaScript code
>  * in this page.
>  */
>
> //--><!]]>
> </script>


>
> my.fsf.org is using the librejs Drupal plugin, but its license code now contains two levels of commenting, which appears to break LibreJS' detection of the license for code on that page.
>


Could you confirm whether this is still a problem?  I checked the donate page and the only blocked script is <https://my.fsf.org/sites/all/modules/civicrm/bower_components/jquery-validation/dist/additional-methods.min.js> which does not have the CDATA.

P.S. I didn't know there's a drupal librejs plugin :)

Yuchen Pei <ycp>
Group administrator
Tue 16 Jun 2020 09:01:22 PM UTC, original submission:  

https://my.fsf.org/donate

"CDATA" is sometimes necessary for XHTML code, but not HTML 5. Despite this, Drupal sometimes marks code with "CDATA" code.


<script type="text/javascript">
<!--//--><![CDATA[//><!--
/**
 * @licstart The following is the entire license notice for the JavaScript
 * code in this page.
...
 * @licend The above is the entire license notice for the JavaScript code
 * in this page.
 */

//--><!]]>
</script>


my.fsf.org is using the librejs Drupal plugin, but its license code now contains two levels of commenting, which appears to break LibreJS' detection of the license for code on that page.

Andrew Engelbrecht <sudoman>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ycp (Posted a comment)
  • -email is unavailable- added by sudoman (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-04-28 ycp Open/ClosedOpen Closed
    2022-04-18 ycp StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code