bugmake - Bugs: bug #54675, avoid redundant recipe warning for...

 
 

bug #54675: avoid redundant recipe warning for identical recipes

Submitter:  David Boyce <boyski>
Submitted:  Tue 18 Sep 2018 01:23:09 AM UTC
   
 
Severity:  3 - Normal Priority:  5 - Normal
Item Group:  Enhancement Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Component Version:  4.3
Operating System:  None Fixed Release:  None
Triage Status:  None
* Mandatory Fields

Post a Comment

Add a New Comment Rich Markup
   

Discussion

Tue 18 Sep 2018 01:23:09 AM UTC, original submission:  

I'm wondering whether it might be reasonable to skip the redundant-recipe warnings if the recipes are identical anyway. Test case:

% cat makefile
.PHONY: all
all:
foo:; touch $@
foo:; touch $@

% make
makefile:5: warning: overriding recipe for target 'foo'
makefile:4: warning: ignoring old recipe for target 'foo'
make: Nothing to be done for 'all'.

It looks like this might be avoidable with a strcmp in read.c around line 2113 (in current SCM) though I'm not in a position to try it now.

This comes up because I have various macros and helper makefiles which generate rules to create directory paths. The recipe to create a directory will in all cases be "mkdir $@" in my use case but when multiple macros end up generating identical rules these spurious warnings are still printed. Of course it can be programmed around but I wonder whether it's worth giving the warning at all here.


David Boyce <boyski>

 

Attached Files

This item currently has no attached files.

(Note: upload size limit is set to 4.0MiB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Dependencies

This item does not depend on any other items.

No items depend on this one.

 

Mail Notification Carbon-Copy List

Carbon-Copy List
  • -email is unavailable- added by boyski (Submitted the item)
  •  

    Votes

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    History

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.16-8b18.
    Corresponding source code