bugPSPP - Bugs: bug #52072, Strange regression with recent GCC...

 
 

bug #52072: Strange regression with recent GCC (or Glibc)

Submitted by:  None
Submitted on:  Wed 20 Sep 2017 02:23:12 PM UTC  
 
Category:  Compilation/Portability Severity:  5 - Average
Status:  Fixed Assigned to:  None
Open/Closed:  Closed Release:  None
Effort:  0.00

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 24 Oct 2017 10:41:24 AM UTC, comment #3: 

Hello and sorry for the delay.

I can confirm - this patch fixed the issue. Thanks!

// Peter Lemenkov <lemenkov at gmail com>

Anonymous
Sat 23 Sep 2017 05:51:59 PM UTC, comment #2: 

I applied the fix.  Please re-open the bug if there still appears to be a problem on PPC64 or PPC64LE (or any other architecture).

Ben Pfaff <blp>
Project Administrator
Wed 20 Sep 2017 03:37:51 PM UTC, comment #1: 

Thanks for the report.

I think I see the problem.  I've attached a patch.  Would you mind testing that it fixes the issue?

Thanks,

Ben.

P.S. I'd like to credit you in the commit log for reporting the bug.  May I have your name?

(file #41844)

Ben Pfaff <blp>
Project Administrator
Wed 20 Sep 2017 02:23:12 PM UTC, original submission:  

Hello All!
Recently PSPP ver. 1.0.1 started to fail passing the tests. The only one failed test is no. 343 (sort-variables.at). Turned out that the following script has different output on PPC64 / PPC64LE arches:

DATA LIST FREE/a b c.
VARIABLE LABEL a "hi there".
SORT VARIABLES  LABEL.
DISPLAY NAMES.
SORT VARIABLES  LABEL  (D).
DISPLAY NAMES.

On x86_64 machine ( https://koji.fedoraproject.org/koji/getfile?taskID=21983571&volume=DEFAULT&name=build.log&offset=-4000 ):

+ ./src/ui/terminal/pspp -O format=csv sort-variables.sps
Variable
b
c
a
Variable
a
c
b

On PPC64 ( https://koji.fedoraproject.org/koji/getfile?taskID=21983574&volume=DEFAULT&name=build.log&offset=-4000 ) or on PPC64LE ( https://koji.fedoraproject.org/koji/getfile?taskID=21983572&volume=DEFAULT&name=build.log&offset=-4000 ):

+ ./src/ui/terminal/pspp -O format=csv sort-variables.sps
Variable
c
b
a
Variable
a
b
c

I'm not very well familiar with PSPP internals to pinpoint exact location where it fails, so I've got stuck. Could someone pinpoint a search area for me where should I look for the regression?

I can't reproduce it on the PPC64 machine (I have access to) with the following versions:

glibc-2.24-9.fc25.ppc64
gcc-6.4.1-1.fc25.ppc64

I can 100% reproduce it with the following packages:

glibc-2.26.90-15.fc28
gcc-7.2.1-1.fc28

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by blp (Updated the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-09-23 blp StatusReady for Test/Review => Fixed
        Open/ClosedOpen => Closed
    2017-09-20 blp Attached File- => Added 0001-SORT-VARIABLES-Improve-stability-of-sort.patch, #41844
        CategoryNone => Compilation/Portability
        StatusNone => Ready for Test/Review

    Back to the top


    Powered by Savane 3.5