bugGNU Screen - Bugs: bug #48983, Crash on new window when the...

 
 

bug #48983: Crash on new window when the terminal type is very long

Submitted by:  None
Submitted on:  Fri 02 Sep 2016 09:41:54 PM UTC  
 
Category: Crash/Freeze/InfloopSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: 4.4.0
Fixed Release: 4.5.0Planned Release: None
Work Required: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 14 Sep 2016 03:30:08 PM UTC, comment #3:

Thanks, corrected.

Amadeusz Sławiński <amade>
Project Administrator
Wed 14 Sep 2016 06:53:59 AM UTC, comment #2:

Note the patch wasn't correctly applied to master. It left both versions of tebuf declared.

http://git.savannah.gnu.org/cgit/screen.git/tree/src/window.c#n904

The screen-v4 branch looks good.

Anonymous
Sat 10 Sep 2016 10:11:17 AM UTC, comment #1:

Thanks for patch, applied to screen-v4 and master branches.

Amadeusz Sławiński <amade>
Project Administrator
Fri 02 Sep 2016 09:41:54 PM UTC, original submission:

screen-4.4.0 built from source using -D_FORTIFY_SOURCE=1 on Fedora 24 crashes when a new window is created using the -T parameter and a sufficiently long string.

The cause seems to be an overflow in the "tebuf" variable and can be fixed with the attached patch. NB: I'm not familiar with the screen source code.

screen does not crash without -D_FORTIFY_SOURCE=1 and it doesn't seem to crash when launching it, but only when creating a new window inside an existing screen session.

I had already reported the bug in the Fedora bugtracker. Initially I was having another problem that turned into the mentioned crash when updating to screen-4.4.0. This is the original bug report:

https://bugzilla.redhat.com/show_bug.cgi?id=1350549

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #38417:  screen-tebuf-fix.diff added by None (829B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by amade (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 18 Jan 2017 09:42:39 PM UTCamadeOpen/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.5.0
    Sat 10 Sep 2016 10:11:17 AM UTCamadeStatusNone=>Fixed
    Fri 02 Sep 2016 09:41:54 PM UTCNoneAttached File-=>Added screen-tebuf-fix.diff, #38417

    Back to the top


    Powered by Savane 3.1-cleanup1