bugGNU Astronomy Utilities - Bugs: bug #48899, Automatic output would not add...


You are not allowed to post comments on this tracker with your current authentication level.

bug #48899: Automatic output would not add suffix if input didn't have a suffix

Submitter:  Mohammad Akhlaghi <makhlaghi>
Submitted:  Thu 25 Aug 2016 02:52:52 PM UTC
Category:  Libraries Severity:  3 - Normal
Item Group:  Output not reasonable Status:  Fixed
Privacy:  Public Assigned to:  makhlaghi
Open/Closed:  Closed

Thu 25 Aug 2016 03:30:36 PM UTC, comment #1: 

A fix has been pushed to the main repo. Please see the commit message and added comments in the code for more details.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Thu 25 Aug 2016 02:52:52 PM UTC, original submission:  

`gal_checkset_automatic_output' plays an important role in setting the output file name of most utilities: it will remove an existing suffix and add the utility-specific suffix. It is called when the user doesn't specify any output.

As described in the comments, this function is suppose to add a suffix is one doesn't exist. However, during my work, I noticed this is not the case: if there is no suffix in the input, there will be no suffix in the output either.

The problem was that the function will write over the space allocated by `gal_checkset_malloc_cat', with an `strcpy' call immediately before the suffix searching loop. I am working on the fix now.

Mohammad Akhlaghi <makhlaghi>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-08-25 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-b921.
    Corresponding source code