bugGNU Astronomy Utilities - Bugs: bug #48899, Automatic output would not add...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48899: Automatic output would not add suffix if input didn't have a suffix

Submitted by:  Mohammad Akhlaghi <makhlaghi>
Submitted on:  Thu 25 Aug 2016 02:52:52 PM UTC  
 
Category: LibrariesSeverity: 3 - Normal
Item Group: Output not reasonableStatus: Fixed
Privacy: PublicAssigned to: Mohammad Akhlaghi <makhlaghi>
Open/Closed: Closed

Thu 25 Aug 2016 03:30:36 PM UTC, comment #1:

A fix has been pushed to the main repo. Please see the commit message and added comments in the code for more details.

Mohammad Akhlaghi <makhlaghi>
Project AdministratorIn charge of this item.
Thu 25 Aug 2016 02:52:52 PM UTC, original submission:

`gal_checkset_automatic_output' plays an important role in setting the output file name of most utilities: it will remove an existing suffix and add the utility-specific suffix. It is called when the user doesn't specify any output.

As described in the comments, this function is suppose to add a suffix is one doesn't exist. However, during my work, I noticed this is not the case: if there is no suffix in the input, there will be no suffix in the output either.

The problem was that the function will write over the space allocated by `gal_checkset_malloc_cat', with an `strcpy' call immediately before the suffix searching loop. I am working on the fix now.

Mohammad Akhlaghi <makhlaghi>
Project AdministratorIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 25 Aug 2016 03:30:36 PM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed

    Back to the top


    Powered by Savane 3.1-cleanup1