bugGNU Astronomy Utilities - Bugs: bug #48770, Typos in ui.c

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48770: Typos in ui.c

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Sat 13 Aug 2016 02:47:47 AM UTC  
 
Category: MakeCatalogSeverity: 3 - Normal
Item Group: Source codeStatus: Fixed
Privacy: PublicAssigned to: Vladimir Markelov <vvm>
Open/Closed: Closed

Sat 13 Aug 2016 02:26:42 PM UTC, comment #4:

You are right about the commit amending! I use it often on my own commits, but it hadn't occurred to me to use it on other commits! Thanks for pointing it out ;-).

The sign-off feature is interesting and a good idea, I'll try it on the next merge, thanks also for this great suggestion ;-).

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sat 13 Aug 2016 11:20:57 AM UTC, comment #3:

Mohammad, you can amend the commit message before pushing to the public repository ;-)

BTW, when you review and install a patch it's a good idea to sign-off it (for example you can use `git am -s file.patch' if you use to work directly with patches file) in order to tell other people who reviewed and accepted the patch.

Mosè Giordano <giordano>
Project Member
Sat 13 Aug 2016 09:55:10 AM UTC, comment #2:

Thanks a lot, it has been merged into the main repo. I am marking this bug as closed.

Just one small point: The current commit guidelines (see the last point) suggest this format for a commit that fixes a bug:

While in this commit, it says:

This just helps in visual inspection (when running `git log' with no options) by conforming with the rest of the commit messages. Its not too important, but it would be great if future commits could also have this format.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Sat 13 Aug 2016 02:50:39 AM UTC, comment #1:

Please see a patch there:

Branch

Patch

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Sat 13 Aug 2016 02:47:47 AM UTC, original submission:

1. Error message in function "printvalues" says that it is "preparearrays"
2. Typo in word 'parsing'

Vladimir Markelov <vvm>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by giordano (Posted a comment)
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 13 Aug 2016 09:55:10 AM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Sat 13 Aug 2016 02:50:39 AM UTCvvmStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1