bugGNU Astronomy Utilities - Bugs: bug #48657, Incorrect error messages in...


You are not allowed to post comments on this tracker with your current authentication level.

bug #48657: Incorrect error messages in convolve.c

Submitter:  Vladimir Markelov <vvm>
Submitted:  Fri 29 Jul 2016 05:39:51 AM UTC
Category:  Convolve Severity:  2 - Minor
Item Group:  Source code Status:  Fixed
Privacy:  Public Assigned to:  vvm
Open/Closed:  Closed

Sat 30 Jul 2016 10:40:58 AM UTC, comment #4: 

Sorry, I just noticed that the markup commands to display code were not sent by email or shown on the webpage, please see the examples on the Savannah markup webpage ;-)

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 30 Jul 2016 10:38:11 AM UTC, comment #3: 

Great! Thanks! It is now merged with master and pushed to the main repo ;-).

Just one point: when breaking the arguments of a function into multiple lines, we start the next line immediately under the opening parenthesis of the function. For example, in the current implementation, the new line is started like below:

    error(EXIT_FAILURE, errno, "%lu bytes for pimg",
                  2*ps0*ps1*sizeof *pimg);

It would be better if it was like this:

    error(EXIT_FAILURE, errno, "%lu bytes for pimg",
          2*ps0*ps1*sizeof *pimg);

I have corrected these in a subsequent commit along with some other cases of lines that were too long.

While making these corrections, I noticed that there was a TAB character at the start of these lines. To make the source code view consistent on any local or web text editor, we have adopted the convention of not using TABs for indentation. So it would be great if you could also avoid TABs in the future ;-).

By the way, to display code nicely in Savannah, you can see the Savannah markup here:


In short you can put the code within two lines of '+verbatim+' and '-verbatim-'.

Mohammad Akhlaghi <makhlaghi>
Group administrator
Sat 30 Jul 2016 03:27:30 AM UTC, comment #2: 
Vladimir Markelov <vvm>
Fri 29 Jul 2016 11:23:17 AM UTC, comment #1: 

Thanks again for this very detailed correction. I just tried fetching from your fork but there was no branch for this correction. Any time its ready, let us know here ;-).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Fri 29 Jul 2016 05:39:51 AM UTC, original submission:  

Two similar places in convolve.c:
205 pimg=p->pimg=malloc(2*ps0*ps1*sizeof *pimg);
206   if(pimg==NULL)
207    error(EXIT_FAILURE, errno, "%lu bytes for pimg", ps0*ps1*sizeof *pimg);

222  pker=p->pker=malloc(2*ps0*ps1*sizeof *pker);
223  if(pker==NULL)
224 error(EXIT_FAILURE, errno, "%lu bytes for pker", ps0*ps1*sizeof *pker);

In both places allocated memory size is twice as bigger as in the error message

Vladimir Markelov <vvm>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by vvm (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-07-30 makhlaghi StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2016-07-29 makhlaghi StatusNone In Progress
    2016-07-29 vvm SummaryIncorrect error mesasge in convolve.c Incorrect error messages in convolve.c

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code