bugGNU Astronomy Utilities - Bugs: bug #48650, Double assing value to the same...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #48650: Double assing value to the same variable instead of two different variables

Submitted by:  Vladimir Markelov <vvm>
Submitted on:  Thu 28 Jul 2016 03:48:24 AM UTC  
 
Category: ConvertTypeSeverity: 3 - Normal
Item Group: Source codeStatus: Fixed
Privacy: PublicAssigned to: Vladimir Markelov <vvm>
Open/Closed: Closed

Thu 28 Jul 2016 07:50:29 AM UTC, comment #2:

Very nice attention at such detail, thank you.

The branch is now merged with master and pushed to the main repo.

Mohammad Akhlaghi <makhlaghi>
Project Administrator
Thu 28 Jul 2016 04:05:51 AM UTC, comment #1:

if you agree that it was bug, please apply the patch from:
https://github.com/VladimirMarkelov/gnuastro-vvm/commits/convertt-assign-min

Patch:
https://github.com/VladimirMarkelov/gnuastro-vvm/commit/1a6670b8233738135f42763ba2e4341fb703e32e

Vladimir Markelov <vvm>
Project MemberIn charge of this item.
Thu 28 Jul 2016 03:48:24 AM UTC, original submission:

src/convertt/convertt.c

Comment says 'Change the minimum and maximum if desired...' but the code block looks:
if(p->fluxlow!=p->fluxhigh)
{
if(p->flminbyte) max=p->fluxlow;
if(p->fhmaxbyte) max=p->fluxhigh;
}

It seems the first assignment should be:
if(p->flminbyte) min = p->fluxlow;

Vladimir Markelov <vvm>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by makhlaghi (Posted a comment)
  • -unavailable- added by vvm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 28 Jul 2016 07:50:29 AM UTCmakhlaghiStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Thu 28 Jul 2016 04:05:51 AM UTCvvmStatusNone=>In Progress

    Back to the top


    Powered by Savane 3.1-cleanup1