GNU Astronomy Utilities - Bugs: bug #48650, Double assing value to the same...

You are not allowed to post comments on this tracker with your current authentication level.

bug #48650: Double assing value to the same variable instead of two different variables

Submitter:	Vladimir Markelov <vvm>
Submitted:	Thu 28 Jul 2016 03:48:24 AM UTC
Category:	ConvertType	Severity:	3 - Normal
Item Group:	Source code	Status:	Fixed
Privacy:	Public	Assigned to:	vvm
Open/Closed:	Closed

Thu 28 Jul 2016 07:50:29 AM UTC, comment #2:  Very nice attention at such detail, thank you. The branch is now merged with master and pushed to the main repo.	Mohammad Akhlaghi <makhlaghi>
Thu 28 Jul 2016 04:05:51 AM UTC, comment #1:  if you agree that it was bug, please apply the patch from: https://github.com/VladimirMarkelov/gnuastro-vvm/commits/convertt-assign-min Patch: https://github.com/VladimirMarkelov/gnuastro-vvm/commit/1a6670b8233738135f42763ba2e4341fb703e32e	Vladimir Markelov <vvm>
Thu 28 Jul 2016 03:48:24 AM UTC, original submission:   src/convertt/convertt.c Comment says 'Change the minimum and maximum if desired...' but the code block looks: if(p->fluxlow!=p->fluxhigh)     {       if(p->flminbyte) max=p->fluxlow;       if(p->fhmaxbyte) max=p->fluxhigh; } It seems the first assignment should be: if(p->flminbyte) min = p->fluxlow;	Vladimir Markelov <vvm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List

-email is unavailable- added by makhlaghi (Posted a comment)

-email is unavailable- added by vvm (Submitted the item)

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date	Changed by	Updated Field	Previous Value	=>	Replaced by
2016-07-28	makhlaghi	Status	In Progress		Fixed
		Open/Closed	Open		Closed
2016-07-28	vvm	Status	None		In Progress

Copyright © 2024 Free Software Foundation, Inc.
Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
Page source code